340.50 KB, image/png
47 bytes, text/x-phabricator-request
|Details | Review|
[Note]: - The heartbeat notification bar is displayed at the bottom of the page instead of the top. [Affected versions]: - (affected) Nightly v65.0a1; - (not affected) Beta v64.0b8; - (not affected) Release v63.0.1. [Affected platforms]: - most likely all, tested on Windows 10 [Pre-conditions:] user_pref("security.content.signature.root_hash", "DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90"); user_pref("app.normandy.api_url", "https://normandy.stage.mozaws.net/api/v1"); user_pref("app.normandy.dev_mode", true); user_pref("app.normandy.logging.level", 0); [Steps to reproduce]: 1. Create/Publish a show-heartbeat recipe. 2. Run a firefox client with the pre-conditions needed for the heartbeat notification to be displayed. [Expected result]: - The heartbeat notification bar is displayed correctly at the top of the page. [Actual result]: - The heartbeat notification bar gets displayed at the bottom of the page. [Regression range]: - The mozregression tool does not work with Normandy experiments; A regression could not be performed. [Additional notes]: - This issue does not occur on the Beta and Release versions of the browser.
Last good revision: 3dd2018ed59a855b06eb7e8404fccc8e499ea4b9 First bad revision: b6676334369f8034686e9c50ceb941a27bfa6674 Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3dd2018ed59a855b06eb7e8404fccc8e499ea4b9&tochange=b6676334369f8034686e9c50ceb941a27bfa6674 Seems like the regression was introduced by bug 1471403 .
Thanks for reporting, I made a typo when rebasing the patch in bug 1471403.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f1d1658e82dd Fix positioning of the high priority notification box. r=dao
I have verified this issue in v65.0a1 from 2018-11-15. Thank you.
You need to log in before you can comment on or make changes to this bug.