1506611 - Enable flake8 linter on more directories under /testing

Status: RESOLVED WONTFIX

(Testing :: General, task, P3)

Description

[Andrew Halberstadt [:ahal]]

Here are the remaining directories with errors:

testing/awsy: 94 errors
testing/firefox-ui: 6 errors
testing/geckodriver: 17 errors
testing/gtest: 19 errors
testing/jsshell: 1 error
testing/marionette: 352 errors
testing/mozharness: 806 errors
testing/runtimes: 10 errors
testing/tools: 72 errors
testing/tps: 57 errors
testing/web-platform: 6473 errors

Let's at least use this bug to tackle the low-hanging fruit (<50 errors). Some of the larger directories will warrant their own bug.

Comment 1

[Andreas Tolfsen ❲:ato❳]

FWIW I don’t particularly think it’s time well spent to fix
testing/marionette before we figure out which Mn tests are duplicated
in WPT (Wd).

I am also working on a deprecation plan for the Marionette Python
client, but we will keep maintaining it for internal use for the
foreseeable future.  Fixing any lint problems specifically with
testing/marionette/client/marionette_driver/**/*.py and
testing/marionette/harness/marionette_harness/*.py (excluding its
test subdirectory) might be worthwhile.

Comment 2

[Andreas Tolfsen ❲:ato❳]

Also, presumably testing/web-platform has its own linting system.

Comment 3

[Vuyisile Ndlovu [:terrameijar]]

Attachment: Bug 1506611 - Fixed linter errors in testing/awsy and testing/geckodriver

Before this change, testing/awsy had 94 errors and testing/geckodriver had 17. The errors have been reduced to 8 and 1 respectively.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41e4eb2f9e47
Fixed linter errors in testing/awsy and testing/geckodriver r=ahal

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/41e4eb2f9e47

Comment 6

[Vuyisile Ndlovu [:terrameijar]]

Attachment: Bug 1506611 - Fixed linter errors in testing/gtest

Before this change, testing/gtest had 19 errors. These errors have been resolved.

Bug 1506611 - Fixed flake8 errors in testing/gtest

Comment 7

[Sylvestre Ledru [:Sylvestre]]

thanks for doing that work :)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/807f9818930a
Fixed linter errors in testing/gtest r=ahal

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/807f9818930a

Comment 10

[Vuyisile Ndlovu [:terrameijar]]

Attachment: Bug 1506611 - Fixed linter errors in testing/tps. r=ahal

Before this change, testing/tps had 19 linter errors. These have been resolved.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad473f67f769
Fixed linter errors in testing/tps. r=ahal

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ad473f67f769

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:gbrown, maybe it's time to close this bug?

Comment 14

[Geoff Brown [:gbrown]]

We've come a long way but it looks like there is more to do - let's keep the bug for now.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 16

[Logan Rosen [:Logan]]

As of Bug 1811850, we now use ruff instead of flake8. Closing as WONTFIX.