Closed
Bug 1506633
Opened 6 years ago
Closed 6 years ago
"Job" link in log viewer is confusing
Categories
(Tree Management :: Treeherder, defect, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aryx, Assigned: camd)
References
Details
(Keywords: regression)
Attachments
(1 file)
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=211191928&repo=autoland&lineNumber=2980 has in the header at the top a "Job" link which is https://treeherder.mozilla.org/#/jobs?job_id=211191928&repo=autoland&searchStr=android%2C8.0%2Cpixel2%2Cdebug%2Cmochitests%2Ctest-android-hw-p2-8-0-arm7-api-16%2Fdebug-mochitest-media-3%2Cm%28mda3%29
It displays the ten most recent pushes and the jobs of the kind of the failing one are displayed but not the one which failed if it is older.
Comment 1•6 years ago
|
||
So counter-intuitively, the "revision" link is currently the link that (once bug 1506630 is fixed at least) is meant to point to the specific job.
The "job" row is the same job row that appears in the job info panel on the main jobs view (the same React component is being used in both places to reduce code duplication). The entry in the job detail panel is meant to filter by last 10 jobs, so it is currently working as "expected".
I do agree that this is confusing and would be something we should perhaps tweak though.
Blocks: 1450045
Flags: needinfo?(cdawson)
Priority: -- → P1
Summary: "Job" link of log viewer supposed to link to failed job but shows most recent jobs of that kind → "Job" link in log viewer is confusing
Comment 2•6 years ago
|
||
Perhaps the link from the log viewer to the jobs view should be a button on the log viewer toolbar, outside of the job info metadata?
Assignee | ||
Comment 3•6 years ago
|
||
(In reply to Ed Morley [:emorley] from comment #2)
> Perhaps the link from the log viewer to the jobs view should be a button on
> the log viewer toolbar, outside of the job info metadata?
Yeah, this is a good idea. I'll do this. Perhaps leave the revision link as well, since people may be used to that. But remove the link for filtering by the job signature/strings. Just make it text.
Assignee: nobody → cdawson
Status: NEW → ASSIGNED
Flags: needinfo?(cdawson)
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/7f3db4090f8f3772bc4a9cbb420770e845a9a7c4
Bug 1506633 - Fix Logviewer links to original job in Treeherder (#4270)
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Updated•3 years ago
|
Component: Treeherder: Log Viewer → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•