Closed Bug 1506642 Opened 2 years ago Closed 2 years ago

dom/tests/mochitest/general/test_interfaces.html | PushManager should be defined on the global scope

Categories

(GeckoView :: General, defect, P5)

defect

Tracking

(firefox66 fixed)

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: snorp)

References

Details

Attachments

(1 file)

Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcab2ed4d7d4
Don't try to test for various Push interfaces on Android r=smaug
Backed out changeset bcab2ed4d7d4 (Bug 1506642) for failures on dom/tests/mochitest/general/test_interfaces.html

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=211482715&revision=bcab2ed4d7d4eb80ecdec900056d78a1789c981b

Backout link: https://hg.mozilla.org/integration/autoland/rev/089ece8bb0353bc6d336e3ebad5635568c62d0c9

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211482715&repo=autoland&lineNumber=1502

[task 2018-11-13T17:33:27.961Z] 17:33:27     INFO -  114 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | Infinity is exposed as an own property on the window but tests false for "in" in the global scope
[task 2018-11-13T17:33:27.962Z] 17:33:27     INFO -  115 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | Infinity is exposed as an own property on the window but has no property descriptor in the global scope
[task 2018-11-13T17:33:27.963Z] 17:33:27     INFO -  116 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface MediaStreamAudioDestinationNode to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2018-11-13T17:33:27.963Z] 17:33:27     INFO -  117 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | MediaStreamAudioDestinationNode is exposed as an own property on the window but tests false for "in" in the global scope
[task 2018-11-13T17:33:27.963Z] 17:33:27     INFO -  118 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | MediaStreamAudioDestinationNode is exposed as an own property on the window but has no property descriptor in the global scope
[task 2018-11-13T17:33:27.963Z] 17:33:27     INFO -  119 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface HTMLTimeElement to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2018-11-13T17:33:27.964Z] 17:33:27     INFO -  120 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | HTMLTimeElement is exposed as an own property on the window but tests false for "in" in the global scope
[task 2018-11-13T17:33:27.965Z] 17:33:27     INFO -  121 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | HTMLTimeElement is exposed as an own property on the window but has no property descriptor in the global scope
[task 2018-11-13T17:33:27.965Z] 17:33:27     INFO -  Buffered messages finished
[task 2018-11-13T17:33:27.966Z] 17:33:27     INFO -  122 INFO TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface PushSubscription to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
[task 2018-11-13T17:33:27.967Z] 17:33:27     INFO -      SimpleTest.ok@SimpleTest/SimpleTest.js:275:7
[task 2018-11-13T17:33:27.968Z] 17:33:27     INFO -      runTest@dom/tests/mochitest/general/test_interfaces.js:1328:5
[task 2018-11-13T17:33:27.969Z] 17:33:27     INFO -      @dom/tests/mochitest/general/test_interfaces.js:1351:1
[task 2018-11-13T17:33:27.969Z] 17:33:27     INFO -  123 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | PushSubscription is exposed as an own property on the window but tests false for "in" in the global scope
[task 2018-11-13T17:33:27.970Z] 17:33:27     INFO -  124 INFO TEST-PASS | dom/tests/mochitest/general/test_interfaces.html | PushSubscription is exposed as an own property on the window but has no property descriptor in the global scope
Flags: needinfo?(snorp)
Attachment #9024481 - Attachment description: Bug 1506642 - Don't try to test for various Push interfaces on Android r=smaug → Bug 1506642 - Don't try to test for various Push interfaces on GeckoView r=smaug
Flags: needinfo?(snorp)
Pushed by jwillcox@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1038391559c9
Don't try to test for various Push interfaces on GeckoView r=smaug
https://hg.mozilla.org/mozilla-central/rev/1038391559c9
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 66 → mozilla66
You need to log in before you can comment on or make changes to this bug.