Closed
Bug 1506660
Opened 7 years ago
Closed 7 years ago
Dispense with TODO comments about bytesWritten in ReadableStream implementation
Categories
(Core :: JavaScript Engine, enhancement, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
The first comment appears in ReadableByteStreamControllerPullSteps. It's OK to
delete it because we just asserted that there are no pending read requests
(step 3.a.).
The second comment appears in JS::ReadableStreamUpdateDataAvailableFromSource.
It's OK to delete this one because it's in the hasDefaultReader branch. Default
readers don't have read requests that care about the number of bytes available.
Attachment #9024542 -
Flags: review?(till)
Comment 2•7 years ago
|
||
Comment on attachment 9024542 [details] [diff] [review]
Dispense with TODO comments about bytesWritten in ReadableStream implementation
Review of attachment 9024542 [details] [diff] [review]:
-----------------------------------------------------------------
rs=me, per our IRC conversation earlier
Attachment #9024542 -
Flags: review?(till) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Updated•7 years ago
|
Attachment #9025632 -
Attachment is obsolete: true
Updated•7 years ago
|
Attachment #9025632 -
Attachment description: Dispense with TODO comments about bytesWritten in ReadableStream implementation. → Bug 1506660 - Dispense with TODO comments about bytesWritten in ReadableStream implementation. r=tschneidereit
Attachment #9025632 -
Attachment is obsolete: false
Updated•7 years ago
|
Attachment #9025632 -
Attachment description: Bug 1506660 - Dispense with TODO comments about bytesWritten in ReadableStream implementation. r=tschneidereit → Bug 1506660 - Dispense with TODO comments about bytesWritten in ReadableStream implementation. r=till
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c5eaa1d4356
Dispense with TODO comments about bytesWritten in ReadableStream implementation. r=till
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•