Dispense with TODO comments about bytesWritten in ReadableStream implementation

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P1
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

8 months ago
No description provided.
Assignee

Comment 1

8 months ago
The first comment appears in ReadableByteStreamControllerPullSteps. It's OK to
delete it because we just asserted that there are no pending read requests
(step 3.a.).

The second comment appears in JS::ReadableStreamUpdateDataAvailableFromSource.
It's OK to delete this one because it's in the hasDefaultReader branch. Default
readers don't have read requests that care about the number of bytes available.
Attachment #9024542 - Flags: review?(till)
Comment on attachment 9024542 [details] [diff] [review]
Dispense with TODO comments about bytesWritten in ReadableStream implementation

Review of attachment 9024542 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, per our IRC conversation earlier
Attachment #9024542 - Flags: review?(till) → review+
Attachment #9025632 - Attachment is obsolete: true
Attachment #9025632 - Attachment description: Dispense with TODO comments about bytesWritten in ReadableStream implementation. → Bug 1506660 - Dispense with TODO comments about bytesWritten in ReadableStream implementation. r=tschneidereit
Attachment #9025632 - Attachment is obsolete: false
Attachment #9025632 - Attachment description: Bug 1506660 - Dispense with TODO comments about bytesWritten in ReadableStream implementation. r=tschneidereit → Bug 1506660 - Dispense with TODO comments about bytesWritten in ReadableStream implementation. r=till

Comment 4

7 months ago
Pushed by jorendorff@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c5eaa1d4356
Dispense with TODO comments about bytesWritten in ReadableStream implementation. r=till

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8c5eaa1d4356
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.