1506846 - The user can not cancel the restart of the browser if he decides to not apply changes after downloading a language

Status: NEW

(Firefox :: Settings UI, defect, P3)

Description

[Cristian Craciun]

Attachment: The user can not cancel the restart of the browser if he decides to not apply changes after downloading a language.png

Preconditions
Set the following preferences from about:config

intl.multilingual.enabled - set to TRUE
intl.multilingual.downloadEnabled - set to TRUE
Go to extensions.getAddons.langpacks.url and past the following link: https://mock-amo-language-tools.glitch.me/ This server provides language packs for Nightly.
extensions.langpacks.signatures.required -set to FALSE
Restart the browser.

[Affected versions]:

Tested on Nightly 65.0a1(2018-11-13)

[Affected platforms]:

All

[Steps to reproduce]:


1. Open "Preferences" and go to the "Language" section
2. Expand the language drop-down and choose Search for more languages..." option
3. User clicks on the dropdown, selects a language and click the "Add" button next to the dropdown
4. Added language appears in the table-first position
5. Alert Windows “Restart Browser / Browser must restart to enable this feature” is displayed
6. User decides to not apply changes

[Expected result]:

A "Cancel" button should be displayed near the "Restart" button. And after the user cancels, the previously added language should be moved to the second position in the list. 

[Actual result]:

The "Cancel" button is not displayed. 

Note: If the user adds a language to the list and then clicks on the cancel button under the list, the language is not displayed anymore in the list. (but the language appears in the dropdown under "installed languages") 

Please see the attachment with the workflow for more details.

Comment 1

[emanuela [ux]]

Instead of 'Cancel', the button should say 'Don't Apply'.

Comment 2

[:Gijs (he/him)]

This doesn't seem critical -> P3.

Comment 3

[ovidiu boca[:Ovidiu]]

The issue is also reproducible on FF 64.0b11