1507004 - Permafail: dom/html/test/test_bug430351.html | <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected ...

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: jwillcox [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=211500833&repo=try

https://queue.taskcluster.net/v1/task/MuCXxDVxShK2RUmE5ahC8g/runs/0/artifacts/public/logs/live_backing.log

This fails currently with GeckoView's TestRunnerActivity. Unknown what the root problem is, but something related to content editable?

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Makoto, wanna take a look?

Comment 2

[Makoto Kato [:m_kato]]

I take this

Comment 3

[Intermittent Failures Robot]

1 failures in 2917 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1

Platform breakdown:
* android-em-7-0-x86: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1507004&startday=2018-11-12&endday=2018-11-18&tree=all

Comment 4

[Intermittent Failures Robot]

1 failures in 2917 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1

Platform breakdown:
* android-em-7-0-x86: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1507004&startday=2018-11-12&endday=2018-11-18&tree=all

Comment 5

[Matthew N. [:MattN]]

This is also a permafailure on macOS when running the test standalone on desktop Firefox:

./mach mochitest dom/html/test/test_bug430351.html
…
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="-1"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe tabindex="-1"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="0"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe tabindex="0"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="0" disabled=""></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe tabindex="0" disabled=""></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="1"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe tabindex="1"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" disabled=""></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe disabled=""></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" contenteditable="true"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe contenteditable="true"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="-1"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe tabindex="-1"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="0"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe tabindex="0"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="0" disabled=""></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe tabindex="0" disabled=""></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="1"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe tabindex="1"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" disabled=""></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe disabled=""></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]

Perhaps this bug should move to a non-GV component or do you want me to file a separate bug for that?

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #5)

This is also a permafailure on macOS when running the test standalone on desktop Firefox:
...
Perhaps this bug should move to a non-GV component or do you want me to file a separate bug for that?

I'll move this bug to the Core::DOM component.

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Sounds like this might be a focus manager bug?

Comment 8

[Neil Deakin]

It looks like this test is doing something similar to:

parent.innerHTML = "<iframe tabindex=0></iframe>";
parent.firstChild.focus()

But the iframe isn't really ready yet so it isn't focusable yet.

Interestingly, there is a line in the test that gets the element.contentDocument in-between setting the content and focusing; this has the effect of initializing the iframe, but it filters out iframes with no src. Removing this filter makes the test pass fine. This is at https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/dom/html/test/test_bug430351.html#464

Comment 9

[Neil Deakin]

Attachment: Bug 1507004, get the contentDocument for all iframes, to ensure that the iframe is focusable, r?peterv

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65f7904484c8
get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/65f7904484c8

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this something you may want to uplift to 67 beta?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This is test-only - let's just take it.

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/77f9f8131845