Closed Bug 1507004 Opened Last year Closed 8 months ago

Permafail: dom/html/test/test_bug430351.html | <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected ...

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: enndeakin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Filed by: jwillcox [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=211500833&repo=try

https://queue.taskcluster.net/v1/task/MuCXxDVxShK2RUmE5ahC8g/runs/0/artifacts/public/logs/live_backing.log

This fails currently with GeckoView's TestRunnerActivity. Unknown what the root problem is, but something related to content editable?
Makoto, wanna take a look?
Flags: needinfo?(m_kato)
I take this
Assignee: nobody → m_kato
Flags: needinfo?(m_kato)
Product: Firefox for Android → GeckoView

This is also a permafailure on macOS when running the test standalone on desktop Firefox:

./mach mochitest dom/html/test/test_bug430351.html

FAIL <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="-1"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe tabindex="-1"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="0"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe tabindex="0"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="0" disabled=""></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe tabindex="0" disabled=""></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="1"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe tabindex="1"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" disabled=""></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe disabled=""></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" contenteditable="true"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe contenteditable="true"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="-1"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe tabindex="-1"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="0"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe tabindex="0"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="0" disabled=""></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe tabindex="0" disabled=""></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" tabindex="1"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe tabindex="1"></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]
FAIL <iframe xmlns="http://www.w3.org/1999/xhtml" disabled=""></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="editableParent" contenteditable="true"><iframe disabled=""></iframe></div> should be focusable - got [object HTMLBodyElement], expected [object HTMLIFrameElement]

Perhaps this bug should move to a non-GV component or do you want me to file a separate bug for that?

Priority: P5 → --
Summary: dom/html/test/test_bug430351.html | <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected ... → Permafail: dom/html/test/test_bug430351.html | <iframe xmlns="http://www.w3.org/1999/xhtml"></iframe> in <div xmlns="http://www.w3.org/1999/xhtml" id="parent"><iframe></iframe></div> should be focusable - got [object HTMLBodyElement], expected ...

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #5)

This is also a permafailure on macOS when running the test standalone on desktop Firefox:
...
Perhaps this bug should move to a non-GV component or do you want me to file a separate bug for that?

I'll move this bug to the Core::DOM component.

Component: General → DOM
Product: GeckoView → Core

Sounds like this might be a focus manager bug?

Assignee: m_kato → nobody
Flags: needinfo?(enndeakin)

It looks like this test is doing something similar to:

parent.innerHTML = "<iframe tabindex=0></iframe>";
parent.firstChild.focus()

But the iframe isn't really ready yet so it isn't focusable yet.

Interestingly, there is a line in the test that gets the element.contentDocument in-between setting the content and focusing; this has the effect of initializing the iframe, but it filters out iframes with no src. Removing this filter makes the test pass fine. This is at https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/dom/html/test/test_bug430351.html#464

Flags: needinfo?(enndeakin)
Assignee: nobody → enndeakin
Priority: -- → P2
Component: DOM → DOM: Core & HTML
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65f7904484c8
get the contentDocument for all iframes, to ensure that the iframe is focusable, r=peterv
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Is this something you may want to uplift to 67 beta?

Flags: needinfo?(enndeakin)

This is test-only - let's just take it.

Flags: needinfo?(enndeakin)
Whiteboard: [checkin-needed-beta]
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.