1507047 - gl_bindings.rs not present in public/build/target.generated-files.tar.gz

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is generated by the Rust `gleam` crate. It's not packaged in public/build/target.generated-files.tar.gz so developers can't get the source that was used to build it in a CI build.

Comment 1

[Mike Hommey [:glandium]]

Isn't that true of all sources generated by rust build scripts?

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Quite possibly. This is just the one I happened to notice.

Comment 3

[(not currently active) Ted Mielczarek]

This used to work, I think we broke it:
https://dxr.mozilla.org/mozilla-central/rev/237e4c0633fda8e227b2ab3ab57e417c980a2811/python/mozbuild/mozbuild/generated_sources.py#49-58

We changed the cargo target dir in bug 1499196 but didn't change that to match (oops):
https://hg.mozilla.org/integration/autoland/rev/470e06d78a7b

It would be nicer if build scripts declared their outputs and we didn't have to grovel around for them. :-/

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: bug 1507047 - fix packaging of generated Rust sources. r?build

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c63f0e550487
fix packaging of generated Rust sources. r=froydnj

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c63f0e550487