Closed Bug 1507047 Opened 10 months ago Closed 10 months ago
_bindings .rs not present in public/build/target .generated-files .tar .gz
47 bytes, text/x-phabricator-request
|Details | Review|
This is generated by the Rust `gleam` crate. It's not packaged in public/build/target.generated-files.tar.gz so developers can't get the source that was used to build it in a CI build.
Isn't that true of all sources generated by rust build scripts?
Quite possibly. This is just the one I happened to notice.
This used to work, I think we broke it: https://dxr.mozilla.org/mozilla-central/rev/237e4c0633fda8e227b2ab3ab57e417c980a2811/python/mozbuild/mozbuild/generated_sources.py#49-58 We changed the cargo target dir in bug 1499196 but didn't change that to match (oops): https://hg.mozilla.org/integration/autoland/rev/470e06d78a7b It would be nicer if build scripts declared their outputs and we didn't have to grovel around for them. :-/
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/c63f0e550487 fix packaging of generated Rust sources. r=froydnj
You need to log in before you can comment on or make changes to this bug.