Closed
Bug 1507066
Opened 6 years ago
Closed 6 years ago
Move the bytecode typemap from BaselineScript to TypeScript
Categories
(Core :: JavaScript Engine, enhancement, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(4 files)
After bug 1499644 all Baseline ICs should work fine without a BaselineScript, except for the type monitoring code because that requires the map stored in BaselineScript.
We should just move that map from BaselineScript to TypeScript. We could even combine it with the bytecode iteration in ICScript::Create (TypeScript always has an ICScript after bug 1499644) so we don't need a second pass for this.
(Maybe we can move JSScript::nTypeSets_ from JSScript to TypeScript at the same time and remove the code for computing that in the frontend.)
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jdemooij
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
We need this for the interpreter so our Baseline ICs work without a BaselineScript.
Also these days TypeScript is a more logical place for it anyway.
This also cleans up the TypeScript allocation code to stop relying on zero
initialization (malloc instead of calloc) and we now use the constructor.
Assignee | ||
Comment 2•6 years ago
|
||
This makes it a bit clearer that it's just the JOF_TYPESET TypeSets and does not
include the arguments/this types.
Depends on D17228
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D17229
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D17477
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f745bbf9f347
part 1 - Move bytecode map from BaselineScript to TypeScript. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ec1aa436aeff
part 2 - Rename JSScript::nTypeSets to JSScript::numBytecodeTypeSets. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/ddf227b9fa75
part 3 - Move the bytecodeTypeMap hint to TypeScript. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/686e61adb628
part 4 - Simplify the bytecodeTypeMap binary search code. r=tcampbell
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f745bbf9f347
https://hg.mozilla.org/mozilla-central/rev/ec1aa436aeff
https://hg.mozilla.org/mozilla-central/rev/ddf227b9fa75
https://hg.mozilla.org/mozilla-central/rev/686e61adb628
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in
before you can comment on or make changes to this bug.
Description
•