Closed
Bug 1507085
Opened 6 years ago
Closed 6 years ago
New XCUITest: Siri Shortcut option in Settings
Categories
(Firefox for iOS :: Build & Test, enhancement)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: isabel_rios, Assigned: isabel_rios)
Details
Attachments
(1 file)
This option was introduced in v14.x.
Not sure that we could automate the whole process of creating a shortcut but at least we should have a XCUITest to check that the option is fine (UXwise) and that it opens Siri.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → irios.mozilla
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9027547 -
Flags: review?(npark)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9027547 [details] [review]
GitHub Pull Request
LGTM, looks like BB failed with Carthage issue?
Attachment #9027547 -
Flags: review?(npark) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
There is a warning about updating Carthage but I don't see this or master (or any other build) failing due to Carthage issue...
|
|
Assignee | |
Comment 4•6 years ago
|
||
Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/c21024b7f222a4c15e3b8ed3fd2045029863ee5d
This will need to be uplifted to v15.x
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]
|
|
Assignee | |
Updated•6 years ago
|
Whiteboard: [needsuplift]
You need to log in
before you can comment on or make changes to this bug.
Description
•