Closed Bug 1507100 Opened 11 months ago Closed 11 months ago

Don't hard-fail when wasm GC and Cranelift are enabled together

Categories

(Core :: Javascript: WebAssembly, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

This causes testing issues (the wasm gc tests fail at initialization of the JSContext, and then leak the world); we could just silently disable the gc if cranelift is enabled, instead.
This caused an early initialization failure in the main() function of the JS
shell, which also caused a full leak warning, and a hard test failure (exit
code was non-zero). This patches silently disables GC when Cranelift is
enabled instead, which translates into soft test failures.
Attachment #9024984 - Attachment description: Bug 1507100: Make wasmTextToBinary generate minimal wasm modules; r?lhansen → Bug 1507100: Don't generate a global section in wasm::TextToBinary if there are no globals; r=lhansen
Attachment #9024983 - Attachment is obsolete: true
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7069cf49cb20
Disable wasm GC when Cranelift is enabled; r=lth
https://hg.mozilla.org/integration/mozilla-inbound/rev/15a5a4be9a35
Don't generate a global section in wasm::TextToBinary if there are no globals; r=lth
https://hg.mozilla.org/mozilla-central/rev/7069cf49cb20
https://hg.mozilla.org/mozilla-central/rev/15a5a4be9a35
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee: nobody → bbouvier
You need to log in before you can comment on or make changes to this bug.