Closed
Bug 1507100
Opened 6 years ago
Closed 6 years ago
Don't hard-fail when wasm GC and Cranelift are enabled together
Categories
(Core :: JavaScript: WebAssembly, enhancement)
Core
JavaScript: WebAssembly
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(2 files, 1 obsolete file)
This causes testing issues (the wasm gc tests fail at initialization of the JSContext, and then leak the world); we could just silently disable the gc if cranelift is enabled, instead.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
|
Assignee | |
Comment 3•6 years ago
|
||
This caused an early initialization failure in the main() function of the JS shell, which also caused a full leak warning, and a hard test failure (exit code was non-zero). This patches silently disables GC when Cranelift is enabled instead, which translates into soft test failures.
|
||
Updated•6 years ago
|
Attachment #9024984 -
Attachment description: Bug 1507100: Make wasmTextToBinary generate minimal wasm modules; r?lhansen → Bug 1507100: Don't generate a global section in wasm::TextToBinary if there are no globals; r=lhansen
|
|
||
Updated•6 years ago
|
Attachment #9024983 -
Attachment is obsolete: true
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7069cf49cb20 Disable wasm GC when Cranelift is enabled; r=lth https://hg.mozilla.org/integration/mozilla-inbound/rev/15a5a4be9a35 Don't generate a global section in wasm::TextToBinary if there are no globals; r=lth
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7069cf49cb20 https://hg.mozilla.org/mozilla-central/rev/15a5a4be9a35
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Updated•6 years ago
|
Assignee: nobody → bbouvier
You need to log in
before you can comment on or make changes to this bug.
Description
•