1507111 - When working on top of an inbound revision, retrieving pushes can fail

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Marco Castelluccio [:marco]]

E.g. today tools/tryselect/selectors/coverage.py was trying to retrieve https://hg.mozilla.org/mozilla-central/json-pushes?version=2&tipsonly=1&tochange=1368e9cf93447804f16e15384be8052f12422e15&startdate=2018-10-15, but 1368e9cf93447804f16e15384be8052f12422e15 is not on mozilla-central yet.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Fallback to latest mozilla-central pushes if the local base revision is not known by hgmo

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 9025077 [details] [diff] [review]
Fallback to latest mozilla-central pushes if the local base revision is not known by hgmo

Review of attachment 9025077 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/tryselect/selectors/coverage.py
@@ +126,5 @@
> +    pushes_data = requests.get(pushes_url + '&tochange={}'.format(base_revision)).json()
> +    if 'error' in pushes_data:
> +        if 'unknown revision' in pushes_data['error']:
> +            print('unknown revision {}, trying with latest mozilla-central revision'.format(base_revision))
> +            pushes_data = requests.get(pushes_url).json()

Not a big deal, but this won't raise an Exception if an error happens in this second call.

Comment 3

[Marco Castelluccio [:marco]]

Attachment: Fallback to latest mozilla-central pushes if the local base revision is not known by hgmo

(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Comment on attachment 9025077 [details] [diff] [review]
> Fallback to latest mozilla-central pushes if the local base revision is not
> known by hgmo
> 
> Review of attachment 9025077 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: tools/tryselect/selectors/coverage.py
> @@ +126,5 @@
> > +    pushes_data = requests.get(pushes_url + '&tochange={}'.format(base_revision)).json()
> > +    if 'error' in pushes_data:
> > +        if 'unknown revision' in pushes_data['error']:
> > +            print('unknown revision {}, trying with latest mozilla-central revision'.format(base_revision))
> > +            pushes_data = requests.get(pushes_url).json()
> 
> Not a big deal, but this won't raise an Exception if an error happens in
> this second call.

Good catch, I've updated the patch to raise an exception in this case too.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b22f5fa0067
Fallback to latest mozilla-central pushes if the local base revision is not known by hgmo. r=ahal

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6b22f5fa0067