1507157 - dom/base/test/test_bug422403-1.html | application crashed [@ MOZ_CrashOOL]

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: jwillcox [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=211585330&repo=try

https://queue.taskcluster.net/v1/task/J4ju-QSIS02Vx5SqDjpQHA/runs/1/artifacts/public/logs/live_backing.log

This crashes in automation when running against TestRunnerActivity

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

This seems to be due to some necko stuff going sideways[0]. Selena, any chance we could get someone to take a look?

[0] https://searchfox.org/mozilla-central/rev/d850d799a0009f851b5535580e0a8b4bb2c591d7/netwerk/ipc/NeckoParent.cpp#177

Comment 2

[Selena Deckelmann :selenamarie :selena]

Valentin - can you have a look?

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1507157 - Set network.disable.ipc.security to true

This pref is left over from B2G days. It is currently disabled for firefox
desktop, but not for Android. This didn't affect us until now because we
always ran Android tests in non-e10s mode.

The pref ought to be removed in bug 1306801.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/335fa26ef0c4
Set network.disable.ipc.security to true r=kershaw

Comment 5

[Intermittent Failures Robot]

1 failures in 2917 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* try: 1

Platform breakdown:
* android-em-7-0-x86: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1507157&startday=2018-11-12&endday=2018-11-18&tree=all

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/335fa26ef0c4

Comment 7

[Chris Peterson [:cpeterson]]

Valentin, does this network.disable.ipc.security issue only affect tests? GeckoView uses e10s in Firefox Focus and Reality. Should we uplift your fix to GeckoView 64 Beta?

Comment 8

[Valentin Gosu [:valentin] (he/him)]

(In reply to Chris Peterson [:cpeterson] from comment #7)
> Valentin, does this network.disable.ipc.security issue only affect tests?
> GeckoView uses e10s in Firefox Focus and Reality. Should we uplift your fix
> to GeckoView 64 Beta?

Mostly xpcshell-tests, and things that create channels without the proper SerializedLoadContext [1].
So for xpcshell-tests, we are creating a channel with certain originAttributes, but the parentProcess doesn't have a tab, so it can't match the load context to any tab.
I assume this doesn't apply to GeckoView. It should be easy to check via crash-stats.

[1] https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/netwerk/ipc/NeckoParent.cpp#161

Comment 9

[Ryan VanderMeulen [:RyanVM]]

This looks like the same crash IIUC:
https://crash-stats.mozilla.com/report/index/02663bb7-7121-40de-b154-7c9ac0181113

Please nominate this for Beta approval when you get a chance, Valentin :)

Comment 10

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 9026087 [details]
Bug 1507157 - Set network.disable.ipc.security to true

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: always present

User impact if declined: Potential crashes in automation (xpcshell-tests, certain mochitests) or uses that don't pass the proper SerializedLoadContext when opening the channel

Is this code covered by automated tests?: Unknown

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This check has been preffed-off for desktop for a very long time. It was only enabled on Android because we didn't use e10s there. Probably low risk.

String changes made/needed:

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9026087 [details]
Bug 1507157 - Set network.disable.ipc.security to true

[Triage Comment]
Android e10s stability fix, approved for 64.0b13 and GV64.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5cb26828de28

Comment 13

[Chris Peterson [:cpeterson]]

status-geckoview64=fixed