1507189 - Replace nsIPresShell::ScrollDirection with an enumset over layers::ScrollDirection

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

We have two ScrollDirection enums. One is defined in the layers code and widely used [1], and the other is defined in nsIPresShell and used in a handful of functions [2]. We should get rid of the latter and use the former. Note that the latter has an eEither option, but we can express that by using an EnumSet<ScrollDirection>, which in fact is already defined at [3].

[1] https://searchfox.org/mozilla-central/search?q=symbol:T_mozilla%3A%3Alayers%3A%3AScrollDirection&redirect=false
[2] https://searchfox.org/mozilla-central/search?q=symbol:T_nsIPresShell%3A%3AScrollDirection&redirect=false
[3] https://searchfox.org/mozilla-central/rev/d850d799a0009f851b5535580e0a8b4bb2c591d7/gfx/layers/apz/src/APZUtils.h#41

Comment 1

[Botond Ballo [:botond]]

The second enum has since been renamed to ScrollableDirection and moved to nsLayoutUtils.h (declared here), but otherwise the described refactoring is still valid.

Stealing mentorship of the bug to use as an intermediate task for our desktop zooming Outreachy project.

Comment 2

[Alaa Emad]

Attachment: Bug 1507189 - Replace nsIPresShell::ScrollDirection with an enumset over layers::ScrollDirection

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9cf73428357c
Replace nsIPresShell::ScrollDirection with an enumset over layers::ScrollDirection r=botond

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9cf73428357c