Closed Bug 1507209 Opened 6 years ago Closed 6 years ago

We fire NavigationDelegate.onLoadError() in cases where Firefox would not show an error page

Categories

(GeckoView :: General, defect, P1)

Product:
GeckoView
Component:
General
Type:
defect

Tracking

(geckoview64 wontfix, firefox63 wontfix, firefox64 wontfix, firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
geckoview64 --- wontfix
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- fixed

People

(Reporter: snorp, Assigned: snorp)

References

Details

Attachments

(1 file)

Bug 1507209 - Don't fire 'onLoadError' if Firefox wouldn't show an error page r=smaug
47 bytes, text/x-phabricator-request
Details | Review
This results in some mochitest failures if we then load an error page in response to onLoadError. We should probably just not fire this if Firefox wouldn't show an error page.
Assignee: nobody → snorp
64=wontfix because we don't need to uplift this test fix to GV 64 Beta.
status-firefox63: --- → wontfix
status-firefox64: --- → wontfix
status-firefox65: --- → affected
Priority: -- → P1
Pushed by jwillcox@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9fa6d8be9e01 Don't fire 'onLoadError' if Firefox wouldn't show an error page r=smaug
https://hg.mozilla.org/mozilla-central/rev/9fa6d8be9e01
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
status-geckoview64=wontfix
status-geckoview64: --- → wontfix
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: