Closed Bug 1507239 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 14055 - [css-properties-values-api] Validate var() fallbacks.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14055 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14055 Details from upstream follow. Anders Hartvoll Ruud <andruud@chromium.org> wrote: > [css-properties-values-api] Validate var() fallbacks. > > According to a recent spec edit, any fallback in a var()-reference must > match the syntax of the referenced property, otherwise the var()-reference > is invalid. This applies even if the fallback is not used. > > To implement this, ResolveFallback now returns kNone/kFail/kSuccess instead > of a bool. This is necessary, because the kNone case may be both an error > state and a success state, depending on whether the fallback is being > used or not, hence a plain bool is not sufficient. > > R=futhark@chromium.org > > Bug: 641877 > Change-Id: I951eef6335bf1cd4064d59959d73ec4fa39c9ee0 > Reviewed-on: https://chromium-review.googlesource.com/1335576 > WPT-Export-Revision: 630e527d8997973db58fdd9b1e157885590f2d69
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2fa696969cc2 [wpt PR 14055] - [css-properties-values-api] Validate var() fallbacks., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/031385cb5558 [wpt PR 14055] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/26acff675876 [wpt PR 14055] - [css-properties-values-api] Validate var() fallbacks., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/bad0f7aa87af [wpt PR 14055] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/26acff675876 https://hg.mozilla.org/mozilla-central/rev/bad0f7aa87af
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.