Closed Bug 1507304 Opened 6 years ago Closed 6 years ago

Date/time pickers throw error after bug 1500620

Categories

(Calendar :: General, defect)

Product:
Calendar
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: darktrojan, Assigned: darktrojan)

References

Details

Attachments

(1 file)

1507304-handler-error-1.diff
3.95 KB, patch
Fallen
: review+
jorgk-bmo
: approval-calendar-beta+
Details | Diff | Splinter Review 
From bug 1500620 comment 32:

This patch causes a lot of warnings on the calendar-event-dialog in our test-logs:
> [task 2018-11-13T18:26:53.016Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 383: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.032Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 383: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.033Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 1442: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.159Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 640: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.160Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 1442: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.202Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 640: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.203Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 1442: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.305Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 383: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.306Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 1442: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.323Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 383: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.326Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 1442: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.436Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 640: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.437Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 1442: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.474Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 640: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.475Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 1442: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.573Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 383: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.574Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 1442: TypeError: this.initialize is not a function
> [task 2018-11-13T18:26:53.764Z] 18:26:53     INFO -  JavaScript error: chrome://calendar/content/datetimepickers/datetimepickers.xml, line 383: TypeError: this.initialize is not a function

This seems to happen on every opening of te dialog.
Attached patch 1507304-handler-error-1.diff — — Splinter Review 
Surprisingly, nothing breaks when you remove a call to a function that doesn't exist from an event handler that's never been fired until now.
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9025174 - Flags: review?(philipp)
Blocks: 1500620
Attachment #9025174 - Flags: review?(philipp) → review+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/cde94d7d4f75
Remove unused event handler causing errors after bug 1500620. r=philipp
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.7
Comment on attachment 9025174 [details] [diff] [review]
1507304-handler-error-1.diff

Follow-up to bug 1500620 which I'm uplifting right now.
Attachment #9025174 - Flags: approval-calendar-beta+
Beta (TB 64 / Cal 6.6 beta 3):
https://hg.mozilla.org/releases/comm-beta/rev/76b887c99b71
Target Milestone: 6.7 → 6.6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: