Closed
Bug 1507313
Opened 6 years ago
Closed 6 years ago
Use UniquePtr for some members in PresShell
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
Details
Attachments
(3 files)
PresShell has some strongly-owned member data that it manages with raw pointers & nsAutoPtr right now, which we should modernize to use UniquePtr. Filing this but on a few patches to do that.
|
Assignee | |
Comment 1•6 years ago
|
||
Also, null out its alias mFrameManager before it's deleted.
|
|
Assignee | |
Comment 2•6 years ago
|
||
Depends on D11945
|
|
Assignee | |
Comment 3•6 years ago
|
||
Depends on D11946
|
|
Assignee | |
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8157c1dea364d26aa34ba59ac1cda555fc20c68a
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/036d7c1beac9 part 1: Convert nsIPresShell::mFrameConstructor into a UniquePtr (rather than an owning raw pointer). r=TYLin https://hg.mozilla.org/integration/autoland/rev/de75d34db695 part 2: Convert PresShell::mReflowCountMgr into a UniquePtr (rather than an owning raw pointer). r=TYLin https://hg.mozilla.org/integration/autoland/rev/ed48b4561f60 part 3: Convert PresShell::mDelayedEvents into an array of UniquePtr (rather than nsAutoPtr). r=TYLin
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/036d7c1beac9 https://hg.mozilla.org/mozilla-central/rev/de75d34db695 https://hg.mozilla.org/mozilla-central/rev/ed48b4561f60
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•