1507313 - Use UniquePtr for some members in PresShell

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Daniel Holbert [:dholbert]]

PresShell has some strongly-owned member data that it manages with raw pointers & nsAutoPtr right now, which we should modernize to use UniquePtr.

Filing this but on a few patches to do that.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1507313 part 1: Convert nsIPresShell::mFrameConstructor into a UniquePtr (rather than an owning raw pointer). r?TYLin

Also, null out its alias mFrameManager before it's deleted.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1507313 part 2: Convert PresShell::mReflowCountMgr into a UniquePtr (rather than an owning raw pointer). r?TYLin

Depends on D11945

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: Bug 1507313 part 3: Convert PresShell::mDelayedEvents into an array of UniquePtr (rather than nsAutoPtr). r?TYLin

Depends on D11946

Comment 4

[Daniel Holbert [:dholbert]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8157c1dea364d26aa34ba59ac1cda555fc20c68a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/036d7c1beac9
part 1: Convert nsIPresShell::mFrameConstructor into a UniquePtr (rather than an owning raw pointer). r=TYLin
https://hg.mozilla.org/integration/autoland/rev/de75d34db695
part 2: Convert PresShell::mReflowCountMgr into a UniquePtr (rather than an owning raw pointer). r=TYLin
https://hg.mozilla.org/integration/autoland/rev/ed48b4561f60
part 3: Convert PresShell::mDelayedEvents into an array of UniquePtr (rather than nsAutoPtr). r=TYLin

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/036d7c1beac9
https://hg.mozilla.org/mozilla-central/rev/de75d34db695
https://hg.mozilla.org/mozilla-central/rev/ed48b4561f60