1507379 - Pretenure count should be available in gecko profiler.

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P3)

Description

[Paul Bone [:pbone]]

A pretenure count is calculated in Nursery::collect, it should be made available in the gecko profiler.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1507379 - Rename gcstats::Stat to gcstats::Count

I want to add a new type of value to Statisticx, which is similar to
Stat but not the same.  This change renames the existing type to Count
(since it's used for counters) and the new one shall be Stat.

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1507379 - Add an object groups pretenured field to GCMinor profiling data

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1507379 - Make some nursery string values available in the profiler

Hi Steve, it is useful to commit this?  Are these nursery-strings related stats likely to change meaning in the future or are they fairly stable?

Comment 4

[Jon Coppeard (:jonco)]

Comment on attachment 9025558 [details] [diff] [review]
Bug 1507379 - Rename gcstats::Stat to gcstats::Count

Review of attachment 9025558 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this name makes more sense.

Comment 5

[Jon Coppeard (:jonco)]

Comment on attachment 9025559 [details] [diff] [review]
Bug 1507379 - Add an object groups pretenured field to GCMinor profiling data

Review of attachment 9025559 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/Statistics.h
@@ +31,4 @@
>  
>  #include "gc/StatsPhasesGenerated.h"
>  
> +// Counts can be incremented with Statistics::count(), they're reset at the end

nit: comma splice.  There should be a full stop before "they're".

@@ +48,4 @@
>      COUNT_LIMIT
>  };
>  
> +// Stats can be set with Statistics::setStat(), they're not reset automatically.

Ditto above.

Comment 6

[Paul Bone [:pbone]]

(In reply to Jon Coppeard (:jonco) from comment #5)
> Comment on attachment 9025559 [details] [diff] [review]
> Bug 1507379 - Add an object groups pretenured field to GCMinor profiling data
> 
> Review of attachment 9025559 [details] [diff] [review]:
> -----------------------------------------------------------------
> 

Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46cc3fa6e65e
Rename gcstats::Stat to gcstats::Count r=jonco
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ab6d3eabd82
Add an object groups pretenured field to GCMinor profiling data r=jonco

Comment 8

[Paul Bone [:pbone]]

Here's the PR for the perf.html part: https://github.com/devtools-html/perf.html/pull/1512

Comment 9

[Steve Fink [:sfink] [:s:]]

Comment on attachment 9025560 [details] [diff] [review]
Bug 1507379 - Make some nursery string values available in the profiler

Review of attachment 9025560 [details] [diff] [review]:
-----------------------------------------------------------------

Both of these seem useful, and (I think) stable. Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47750e022e23
Make some nursery string values available in the profiler r=sfink

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/47750e022e23

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/46cc3fa6e65e
https://hg.mozilla.org/mozilla-central/rev/5ab6d3eabd82