Closed
Bug 1507379
Opened 6 years ago
Closed 6 years ago
Pretenure count should be available in gecko profiler.
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: pbone, Assigned: pbone)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
7.41 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
2.97 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
3.21 KB,
patch
|
sfink
:
review+
sfink
:
feedback+
|
Details | Diff | Splinter Review |
A pretenure count is calculated in Nursery::collect, it should be made available in the gecko profiler.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → pbone
Status: NEW → ASSIGNED
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
I want to add a new type of value to Statisticx, which is similar to
Stat but not the same. This change renames the existing type to Count
(since it's used for counters) and the new one shall be Stat.
Attachment #9025558 -
Flags: review?(jcoppeard)
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #9025559 -
Flags: review?(jcoppeard)
Assignee | ||
Comment 3•6 years ago
|
||
Hi Steve, it is useful to commit this? Are these nursery-strings related stats likely to change meaning in the future or are they fairly stable?
Attachment #9025560 -
Flags: feedback?(sphink)
Comment 4•6 years ago
|
||
Comment on attachment 9025558 [details] [diff] [review]
Bug 1507379 - Rename gcstats::Stat to gcstats::Count
Review of attachment 9025558 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks, this name makes more sense.
Attachment #9025558 -
Flags: review?(jcoppeard) → review+
Comment 5•6 years ago
|
||
Comment on attachment 9025559 [details] [diff] [review]
Bug 1507379 - Add an object groups pretenured field to GCMinor profiling data
Review of attachment 9025559 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/gc/Statistics.h
@@ +31,4 @@
>
> #include "gc/StatsPhasesGenerated.h"
>
> +// Counts can be incremented with Statistics::count(), they're reset at the end
nit: comma splice. There should be a full stop before "they're".
@@ +48,4 @@
> COUNT_LIMIT
> };
>
> +// Stats can be set with Statistics::setStat(), they're not reset automatically.
Ditto above.
Attachment #9025559 -
Flags: review?(jcoppeard) → review+
Assignee | ||
Comment 6•6 years ago
|
||
(In reply to Jon Coppeard (:jonco) from comment #5)
> Comment on attachment 9025559 [details] [diff] [review]
> Bug 1507379 - Add an object groups pretenured field to GCMinor profiling data
>
> Review of attachment 9025559 [details] [diff] [review]:
> -----------------------------------------------------------------
>
Thanks.
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46cc3fa6e65e
Rename gcstats::Stat to gcstats::Count r=jonco
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ab6d3eabd82
Add an object groups pretenured field to GCMinor profiling data r=jonco
Assignee | ||
Comment 8•6 years ago
|
||
Here's the PR for the perf.html part: https://github.com/devtools-html/perf.html/pull/1512
Comment 9•6 years ago
|
||
Comment on attachment 9025560 [details] [diff] [review]
Bug 1507379 - Make some nursery string values available in the profiler
Review of attachment 9025560 [details] [diff] [review]:
-----------------------------------------------------------------
Both of these seem useful, and (I think) stable. Thanks!
Attachment #9025560 -
Flags: review+
Attachment #9025560 -
Flags: feedback?(sphink)
Attachment #9025560 -
Flags: feedback+
Comment 10•6 years ago
|
||
Pushed by pbone@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/47750e022e23
Make some nursery string values available in the profiler r=sfink
Comment 11•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 12•6 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•