1507467 - Make sure mAfterOnStartRequestBegun is true for channels loaded with LOAD_ONLY_IF_MODIFIED

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

(In reply to Michal Novotny [:michal] from bug 1358038 comment #54)
> While inspecting the logs I found a special case when it doesn't work
> correctly. If LOAD_ONLY_IF_MODIFIED flag is used, we don't read the data,
> nsHttpChannel::OnStartRequest isn't called and mAfterOnStartRequestBegun is
> false. I think it's a bug because although nsHttpChannel::OnStartRequest was
> omitted, according to meaning of mAfterOnStartRequestBegun it should be IMO
> true. We could set it to true in HttpBaseChannel::DoNotifyListener if it's
> false there.

Comment 1

[Michal Novotny [:michal]]

Attachment: fix

https://treeherder.mozilla.org/#/jobs?repo=try&revision=928b46e11f5a9e3870aa1b897f348926f2bd5394&selectedJob=216364887

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20d117d3ed6b
Make sure mAfterOnStartRequestBegun is true for channels loaded with LOAD_ONLY_IF_MODIFIED, r=valentin

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/20d117d3ed6b