Closed Bug 1507467 Opened 6 years ago Closed 5 years ago

Make sure mAfterOnStartRequestBegun is true for channels loaded with LOAD_ONLY_IF_MODIFIED

Categories

(Core :: Networking: Cache, enhancement, P3)

Product:
Core
Component:
Networking: Cache
Version:
60 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: valentin, Assigned: michal)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

fix
1.25 KB, patch
valentin
: review+
Details | Diff | Splinter Review 
(In reply to Michal Novotny [:michal] from bug 1358038 comment #54)
> While inspecting the logs I found a special case when it doesn't work
> correctly. If LOAD_ONLY_IF_MODIFIED flag is used, we don't read the data,
> nsHttpChannel::OnStartRequest isn't called and mAfterOnStartRequestBegun is
> false. I think it's a bug because although nsHttpChannel::OnStartRequest was
> omitted, according to meaning of mAfterOnStartRequestBegun it should be IMO
> true. We could set it to true in HttpBaseChannel::DoNotifyListener if it's
> false there.
Priority: -- → P5
Priority: P5 → P3
Attachment #9030702 - Flags: review?(valentin.gosu) → review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20d117d3ed6b
Make sure mAfterOnStartRequestBegun is true for channels loaded with LOAD_ONLY_IF_MODIFIED, r=valentin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/20d117d3ed6b
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: