1507475 - [Wayland] Crash when display is changed

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Description of problem:
Firefox-wayland crashes on display switch. I have two displays one for standing, second for sitting. Switching display through gnome-control-center causes firefox-wayland crash.

Version-Release number of selected component (if applicable):
firefox-63.0.1-5.fc29.x86_64
firefox-wayland-63.0.1-5.fc29.x86_64

How reproducible:
* Attach 2 displays A and B
* Disable  display B
* Start firefox-wayland
* run gnome-control-center Display settings
* disable display A and enable display B, apply
* -> Firefox-wayland crash

Steps to Reproduce:
* Attach 2 displays A and B
* Disable  display B
* Start firefox-wayland
* run gnome-control-center Display settings
* disable display A and enable display B, apply
* -> Firefox-wayland crash

Actual results:
Firefox-wayland crash

Expected results:
Application should not crash. Windows should be placed on newly activated display

Additional info:
Default Firefox using Xwayland works normally.

Downstream bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1647776

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It's because moz_container_init() is called and puts container to data field at registry. Then wl_output is called (monitor change) and when the container is already deleted we're accessing freed data.

A solution may be to create one global registry wayland object and don't query registry in particular modules.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

We need to call wl_display_get_registry() only once and use the object globally.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1507475 - [Wayland] Implement global wayland registry, r=jhorak

Comment 4

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0e068cac7596b4bdc9738a127f1c6dc2dfd0919

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bafd708f5788
[Wayland] Implement global wayland registry, r=jhorak

Comment 6

[Noemi Erli[:noemi_erli]]

Backed out changeset bafd708f5788 (Bug 1507475) for bustages in builds/worker/workspace/build/src/widget/gtk/mozcontainer.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=213397381&revision=bafd708f5788ec19c3eda5a4068f2a56fb9f4e7a

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=213397381&repo=autoland&lineNumber=27789

Backout: https://hg.mozilla.org/integration/autoland/rev/499f784117935508bfc6b8c848b4cad347f255fe

Comment 7

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a39825ef7f2a12a0e9cb724d5a14a35082fc203

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Thanks, there's an updated one.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca9f1be1f8e8
[Wayland] Implement global wayland registry, r=jhorak

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ca9f1be1f8e8