1507476 - Track Changes - Renaming a CSS property is not tracked

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Martin Balfanz [:mbalfanz]]

STR:
- Open devtools at any page
- Change a property, e.g. `padding` -> `margin` without changing the value
- Have a look at the changes panel

ER:
- Changes panel should show the padding as removed and margin as added

AR:
- Changes panel remains blank

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1507476 - Match exact tracked declaration when renaming a property. r=pbro

Ensure the exact declaration is matched when aggregating changes and attemtping to remove declarations which cancel each other out.
Without checking both the index and the property name, we used to lose tracked declarations that were renamed.

The test checks for the expected rename behavor and that renaming the declaration to its original clears any tracked changes.

Comment 2

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1507476 - Update Changes panel tests to use helpers for rendered declarations. r=pbro

Depends on D12434

Comment 3

[Razvan Caliman [:rcaliman]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=25334499e0259de1cc09bb88ec725b0d2b92c5ea

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67ae9d053896
Match exact tracked declaration when renaming a property. r=pbro
https://hg.mozilla.org/integration/autoland/rev/658cd029a6a1
Update Changes panel tests to use helpers for rendered declarations. r=pbro

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/67ae9d053896
https://hg.mozilla.org/mozilla-central/rev/658cd029a6a1