Closed Bug 1507476 Opened 1 year ago Closed 1 year ago

Track Changes - Renaming a CSS property is not tracked

Categories

(DevTools :: Inspector, defect, P2)

65 Branch
defect

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: mbalfanz, Assigned: rcaliman)

References

Details

Attachments

(2 files)

STR:
- Open devtools at any page
- Change a property, e.g. `padding` -> `margin` without changing the value
- Have a look at the changes panel

ER:
- Changes panel should show the padding as removed and margin as added

AR:
- Changes panel remains blank
Priority: -- → P2
Summary: Property changes are not tracked → Track Changes - Renaming a CSS property is not tracked
Blocks: 1508353
Assignee: nobody → rcaliman
Ensure the exact declaration is matched when aggregating changes and attemtping to remove declarations which cancel each other out.
Without checking both the index and the property name, we used to lose tracked declarations that were renamed.

The test checks for the expected rename behavor and that renaming the declaration to its original clears any tracked changes.
Status: NEW → ASSIGNED
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67ae9d053896
Match exact tracked declaration when renaming a property. r=pbro
https://hg.mozilla.org/integration/autoland/rev/658cd029a6a1
Update Changes panel tests to use helpers for rendered declarations. r=pbro
https://hg.mozilla.org/mozilla-central/rev/67ae9d053896
https://hg.mozilla.org/mozilla-central/rev/658cd029a6a1
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.