1507566 - Profiler Counters not showing up in profile outputs when forcebly injected into SpiderMonkey

Status: NEW

(Core :: Gecko Profiler, enhancement, P2)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Kludgy-Profile-Counters.patch

Until Bug 1505589 is fixed, we can't use the newly added Profiler Counters (Bug 
1464509) in any way that could be landed. 

But, I thought -maybe-, I would be able to use them from with relative ease for experimentation purposes in a way that -can't- be landed. 

See the attached patch. 

However, when I run 

  MOZ_PROFILER_SHUTDOWN=$PWD/ProfilerOutput ./mach run --disable-e10s

and profile some page where I expect to see counter increments, I am unable to find any results. 

I used https://www.facebook.com/videogamers/, which I know from another logging method to trigger indexed property deletion thousands of times by just scrolling. 

Given that AFAICT there are no live instances of the profiler counters right now, I don't know if the fact that I'm not seeing output is a bug in my kludgy connection, or if the counters themselves aren't being output as expected.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Thanks to :mstange on IRC, I was able to check the raw profile emitted by MOZ_PROFILER_SHUTDOWN, and confirm that there is a top level counters property. It however only has memory counter info; in my patch the counters don't show up.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: hacky patch to enable Shape counters Not For Checkin