1507599 - top stories more Recommendations link showing up for German locale even though page is English

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Scott [:thecount] Downe]

Steps to test:

1. Build or download a German copy of the browser.
2. Go to about:home

Expected: should not see a "more Recommendations" link.
Actual: you do see a "more Recommendations" and the page it links to is in English.

Pretty sure this was caused by bug #1483655

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4567

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/52c7e5aa3cedba1fe6bb6c713fe146b42185b777
bug 1507599 - top stories more Recommendations link showing up for German locale even though page is English (#4567)

Comment 3

[Scott [:thecount] Downe]

Attachment: Beta uplift: Bug 1507599 - Top stories more Recommendations link showing up for German locale even though page is English.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 9026822 [details]
Beta uplift: Bug 1507599 - Top stories more Recommendations link showing up for German locale even though page is English.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1483655

User impact if declined: Germans see an link that goes to an English page.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: 1. Build or download a German copy of the browser.
2. Go to about:home

Expected: should not see a "more Recommendations" link.
Actual: you do see a "more Recommendations" and the page it links to is in English.

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It's a low amount of changes with little complexity. I'm confident in the changes.

String changes made/needed: None

Comment 5

[Ryan VanderMeulen [:RyanVM]]

This was fixed on trunk via bug 1509565, but I can't set the dependency due to circular dependencies.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9026822 [details]
Beta uplift: Bug 1507599 - Top stories more Recommendations link showing up for German locale even though page is English.

[Triage Comment]
Fixes Germans seeing links for English pages in Top Stories. Approved for 64.0b13.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b519e727ee9e

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/973e2824df96

Comment 9

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Beta DE locale build (64.0b13 Build ID - 20181126173133) and with the latest Firefox Nightly DE locale (65.0a1 Build ID - 20181126100057) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the "More Recommendations" link is no longer displayed in the "Recommended by Pocket" area.