Closed Bug 1507819 Opened 2 years ago Closed 2 years ago

Update to Cranelift 0.24

Categories

(Core :: Javascript: WebAssembly, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: sunfish, Assigned: sunfish)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch cranelift-0.24 (obsolete) — Splinter Review
This updates to Cranelift 0.24, which contains various bug fixes, including a potential fix for bug 1506511.

Unfortunately, it's blocked at the moment apparently due to bug 1500167 landing. I tested it by locally reverting that patch.
Attached patch cranelift-0.25Splinter Review
This updates to Cranelift 0.25, which notably includes some wasmparser bug fixes.
Assignee: nobody → sunfish
Attachment #9025684 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #9027826 - Flags: review?(bbouvier)
Comment on attachment 9027826 [details] [diff] [review]
cranelift-0.25

Review of attachment 9027826 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, since this is just touching Cargo.toml and mach vendor rust, as far as I can tell. Let's ship it!
Attachment #9027826 - Flags: review?(bbouvier) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3d330442ef3b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Blocks: 1610542
Type: defect → task
No longer blocks: cranelift
You need to log in before you can comment on or make changes to this bug.