Perma devtools/client/inspector/markup/test/browser_markup_display_node_ [01/02].js | #flex display node is shown | Uncaught exception - at chrome.. | Display badge is visible When Gecko 65 merges to Beta on 2018-12-03

VERIFIED FIXED in Firefox 65

Status

defect
P3
normal
VERIFIED FIXED
8 months ago
8 months ago

People

(Reporter: bogdan_tara, Assigned: gl)

Tracking

unspecified
Firefox 65
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox63 unaffected, firefox64 unaffected, firefox65+ verified)

Details

Attachments

(1 attachment)

[Tracking Requested - why for this release]:

https://treeherder.mozilla.org/logviewer.html#?job_id=212225630&repo=try&lineNumber=2915

https://taskcluster-artifacts.net/EZeFcrsRRHSsLM2QNGgqOw/0/public/logs/live_backing.log

[task 2018-11-16T14:36:59.834Z] 14:36:59     INFO - Getting the markup-container for node #flex
[task 2018-11-16T14:36:59.851Z] 14:36:59     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_display_node_01.js | Found markup-container for selector: #flex - 
[task 2018-11-16T14:36:59.851Z] 14:36:59     INFO - TEST-INFO | started process screentopng
[task 2018-11-16T14:37:00.338Z] 14:37:00     INFO - TEST-INFO | screentopng: exit 0
[task 2018-11-16T14:37:00.342Z] 14:37:00     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_display_node_01.js | #flex display node is shown. - 
[task 2018-11-16T14:37:00.343Z] 14:37:00     INFO - Stack trace:
[task 2018-11-16T14:37:00.344Z] 14:37:00     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2018-11-16T14:37:00.344Z] 14:37:00     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_01.js:null:62
[task 2018-11-16T14:37:00.346Z] 14:37:00     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-16T14:37:00.347Z] 14:37:00     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_display_node_01.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_01.js:63 - TypeError: flexDisplayNode is null; can't access its "textContent" property
[task 2018-11-16T14:37:00.349Z] 14:37:00     INFO - Stack trace:
[task 2018-11-16T14:37:00.350Z] 14:37:00     INFO - @chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_01.js:63:3
[task 2018-11-16T14:37:00.351Z] 14:37:00     INFO - Leaving test bound 
...
[task 2018-11-16T14:37:02.463Z] 14:37:02     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_display_node_02.js | Container is part of the list of changed nodes - 
[task 2018-11-16T14:37:02.465Z] 14:37:02     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-16T14:37:02.466Z] 14:37:02     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_display_node_02.js | Display badge is visible as expected for #flex: true - Got false, expected true
[task 2018-11-16T14:37:02.467Z] 14:37:02     INFO - Stack trace:
[task 2018-11-16T14:37:02.468Z] 14:37:02     INFO - chrome://mochikit/content/browser-test.js:test_is:1303
[task 2018-11-16T14:37:02.469Z] 14:37:02     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_02.js:runTestData:143
[task 2018-11-16T14:37:02.470Z] 14:37:02     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-16T14:37:02.471Z] 14:37:02     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_display_node_02.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_02.js:146 - TypeError: afterBadge is null; can't access its "textContent" property
[task 2018-11-16T14:37:02.472Z] 14:37:02     INFO - Stack trace:
[task 2018-11-16T14:37:02.473Z] 14:37:02     INFO - runTestData@chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_02.js:146:5
[task 2018-11-16T14:37:02.474Z] 14:37:02     INFO - Leaving test bound
Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: -- → P3
Depends on: 1498115
Judging from the screenshot from the failures, we can see that the flex display badge is white (ie, not interactive), which is why it cannot find the display badge since it doesn't have the interactive class, and why it wasn't failing previously.

We push the devtools.inspector.flexboxHighlighter.enabled for these 2 tests to ensure we are rendering an interactive display badge.
Attachment #9026208 - Flags: review?(pbrosset)
Attachment #9026208 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e25e40a58667
Push the devtools.inspector.flexboxHighlighter.enabled pref in browser_markup_display_node[01/02].js; r=pbro
https://hg.mozilla.org/mozilla-central/rev/e25e40a58667
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.