1507844 - Perma devtools/client/inspector/markup/test/browser_markup_display_node_ [01/02].js | #flex display node is shown | Uncaught exception - at chrome.. | Display badge is visible When Gecko 65 merges to Beta on 2018-12-03

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Bogdan Tara[:bogdan_tara | bogdant]]

[Tracking Requested - why for this release]:

https://treeherder.mozilla.org/logviewer.html#?job_id=212225630&repo=try&lineNumber=2915

https://taskcluster-artifacts.net/EZeFcrsRRHSsLM2QNGgqOw/0/public/logs/live_backing.log

[task 2018-11-16T14:36:59.834Z] 14:36:59     INFO - Getting the markup-container for node #flex
[task 2018-11-16T14:36:59.851Z] 14:36:59     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_display_node_01.js | Found markup-container for selector: #flex - 
[task 2018-11-16T14:36:59.851Z] 14:36:59     INFO - TEST-INFO | started process screentopng
[task 2018-11-16T14:37:00.338Z] 14:37:00     INFO - TEST-INFO | screentopng: exit 0
[task 2018-11-16T14:37:00.342Z] 14:37:00     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_display_node_01.js | #flex display node is shown. - 
[task 2018-11-16T14:37:00.343Z] 14:37:00     INFO - Stack trace:
[task 2018-11-16T14:37:00.344Z] 14:37:00     INFO - chrome://mochikit/content/browser-test.js:test_ok:1292
[task 2018-11-16T14:37:00.344Z] 14:37:00     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_01.js:null:62
[task 2018-11-16T14:37:00.346Z] 14:37:00     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-16T14:37:00.347Z] 14:37:00     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_display_node_01.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_01.js:63 - TypeError: flexDisplayNode is null; can't access its "textContent" property
[task 2018-11-16T14:37:00.349Z] 14:37:00     INFO - Stack trace:
[task 2018-11-16T14:37:00.350Z] 14:37:00     INFO - @chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_01.js:63:3
[task 2018-11-16T14:37:00.351Z] 14:37:00     INFO - Leaving test bound 
...
[task 2018-11-16T14:37:02.463Z] 14:37:02     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_display_node_02.js | Container is part of the list of changed nodes - 
[task 2018-11-16T14:37:02.465Z] 14:37:02     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-16T14:37:02.466Z] 14:37:02     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_display_node_02.js | Display badge is visible as expected for #flex: true - Got false, expected true
[task 2018-11-16T14:37:02.467Z] 14:37:02     INFO - Stack trace:
[task 2018-11-16T14:37:02.468Z] 14:37:02     INFO - chrome://mochikit/content/browser-test.js:test_is:1303
[task 2018-11-16T14:37:02.469Z] 14:37:02     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_02.js:runTestData:143
[task 2018-11-16T14:37:02.470Z] 14:37:02     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-11-16T14:37:02.471Z] 14:37:02     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_display_node_02.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_02.js:146 - TypeError: afterBadge is null; can't access its "textContent" property
[task 2018-11-16T14:37:02.472Z] 14:37:02     INFO - Stack trace:
[task 2018-11-16T14:37:02.473Z] 14:37:02     INFO - runTestData@chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_display_node_02.js:146:5
[task 2018-11-16T14:37:02.474Z] 14:37:02     INFO - Leaving test bound

Comment 1

[Intermittent Failures Robot]

141 failures in 585 pushes (0.241 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 141

Platform breakdown:
* linux64: 24
* windows7-32-nightly: 15
* windows10-64-nightly: 15
* windows10-64: 18
* linux64-nightly: 14
* macosx64-nightly: 14
* linux32-nightly: 16
* osx-10-10: 14
* windows7-32: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1507844&startday=2018-11-16&endday=2018-11-16&tree=all

Comment 2

[Intermittent Failures Robot]

141 failures in 2917 pushes (0.048 failures/push) were associated with this bug in the last 7 days.

This is the #5 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. ** 

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 141

Platform breakdown:
* windows7-32: 11
* linux64-nightly: 14
* linux32-nightly: 16
* linux64: 24
* osx-10-10: 14
* windows10-64: 18
* windows7-32-nightly: 15
* macosx64-nightly: 14
* windows10-64-nightly: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1507844&startday=2018-11-12&endday=2018-11-18&tree=all

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1507844.patch [1.0]

Judging from the screenshot from the failures, we can see that the flex display badge is white (ie, not interactive), which is why it cannot find the display badge since it doesn't have the interactive class, and why it wasn't failing previously.

We push the devtools.inspector.flexboxHighlighter.enabled for these 2 tests to ensure we are rendering an interactive display badge.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e25e40a58667
Push the devtools.inspector.flexboxHighlighter.enabled pref in browser_markup_display_node[01/02].js; r=pbro

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e25e40a58667

Comment 6

[Eliza Balazs [:ebalazs_]]

Verified fixed with today's beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=9874af9fcaa8b20952dc65c4869a3ce1b0c0a01e