Record refcount changes for image decoders and decoding tasks

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: bhackett, Assigned: bhackett)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

7 months ago
Posted patch patchSplinter Review
There have been some mismatches when using Web Replay that seem like they are due to image::Decoders being destroyed on inconsistent threads between recording and replaying.  I'm not sure if this is due to inconsistent releases of the last references on the Decoder itself or the IDecodingTask which references it, so the attached patch ensures that references on each of these classes are recorded and replayed consistently.
Assignee

Comment 1

7 months ago
Currently, classes which implement their refcounting via the NS_INLINE_DECL_THREADSAFE_REFCOUNTING or NS_INLINE_DECL_THREADSAFE_VIRTUAL_REFCOUNTING macros do not have a way to specify that their refcount changes should be recorded.  This patch adds additional macros to support this.
Attachment #9025910 - Flags: review?(nfroyd)
Assignee

Comment 2

7 months ago
Record changes to reference counts on Decoder and IDecodingTask.
Attachment #9025911 - Flags: review?(tnikkel)
Attachment #9025911 - Flags: review?(tnikkel) → review+
Attachment #9025910 - Flags: review?(nfroyd) → review+

Comment 3

7 months ago
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/456275c5ddac
Part 1 - Add macros for recording refcounts on non-nsISupports classes, r=froydnj.
https://hg.mozilla.org/integration/mozilla-inbound/rev/98430e6d541b
Part 2 - Record refcount changes for image decoders and decoding tasks, r=tnikkel.

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/456275c5ddac
https://hg.mozilla.org/mozilla-central/rev/98430e6d541b
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.