1508099 - Record refcount changes for image decoders and decoding tasks

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

There have been some mismatches when using Web Replay that seem like they are due to image::Decoders being destroyed on inconsistent threads between recording and replaying.  I'm not sure if this is due to inconsistent releases of the last references on the Decoder itself or the IDecodingTask which references it, so the attached patch ensures that references on each of these classes are recorded and replayed consistently.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Part 1 - Add macros for recording refcounts on non-nsISupports classes.

Currently, classes which implement their refcounting via the NS_INLINE_DECL_THREADSAFE_REFCOUNTING or NS_INLINE_DECL_THREADSAFE_VIRTUAL_REFCOUNTING macros do not have a way to specify that their refcount changes should be recorded.  This patch adds additional macros to support this.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Part 2 - Record refcount changes for image decoders and decoding tasks.

Record changes to reference counts on Decoder and IDecodingTask.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/456275c5ddac
Part 1 - Add macros for recording refcounts on non-nsISupports classes, r=froydnj.
https://hg.mozilla.org/integration/mozilla-inbound/rev/98430e6d541b
Part 2 - Record refcount changes for image decoders and decoding tasks, r=tnikkel.

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/456275c5ddac
https://hg.mozilla.org/mozilla-central/rev/98430e6d541b