Open Bug 1508116 Opened 6 years ago Updated 2 years ago

4-5ms spent scene building new Gmail (scene building is too slow)

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Type:
defect

Tracking

()

People

(Reporter: jrmuizel, Unassigned)

References

(Blocks 2 open bugs)

Details

STR:
- put the new gmail in compact mode
- move the mouse over a bunch of rows

https://perfht.ml/2KaMLcw

Half of the time (54%) is spent in realloc.
Another 10% is spent in malloc.
Blocks: stage-wr-trains
Priority: -- → P2
Depends on: content-full-paint-time
Blocks: content-full-paint-time
No longer depends on: content-full-paint-time
This ties into the profiling work I and :gw have been doing. I'm currently working on refactoring WR SceneBuilder to alleviate the realloc/malloc hit.

The work on the issues will be tracked in WR Github issues.
Assignee: nobody → dglastonbury
Summary: 6-7ms spent scene building new Gmail → 6-7ms spent scene building new Gmail (scene building is too slow)
Is there more work we anticipate doing here?
Flags: needinfo?(dglastonbury)

@jrmuizel there is more work that I want to do to remove the last realloc/malloc churn I saw in the WR backend.

Flags: needinfo?(dglastonbury)

I just profiled on my macOS and gmail looks really smooth. No dropped frames. Each thread spending 99% idle. So I'd be happy to close this bug, @jrmuizel.

Flags: needinfo?(jmuizelaar)

I still have an appreciable amount of time in scene building on gmail. https://perfht.ml/2C6ljJf

But happy to make this not block.

Blocks: stage-wr-next
No longer blocks: stage-wr-trains
Flags: needinfo?(jmuizelaar)
Summary: 6-7ms spent scene building new Gmail (scene building is too slow) → 4-5ms spent scene building new Gmail (scene building is too slow)
Blocks: wr-perf
No longer blocks: wr-perf
Priority: P2 → P3
Assignee: dan.glastonbury → nobody
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.