Open Bug 1508254 Opened 5 years ago Updated 11 months ago

Change referrerpolicy nstring filed to enum ReferrerPolicy in speculative loading

Categories

(Core :: DOM: HTML Parser, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: tnguyen, Unassigned, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(3 files)

Follow up bug 1460920, we should remove the usage of nstring referrerPolicy in 
https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/parser/html/nsHtml5SpeculativeLoad.h#271
to use enum mozilla::net::ReferrerPolicy
Mentor: hsivonen
Keywords: good-first-bug
Priority: -- → P3

Hello,I would like to work on this bug

Hi if nobody is working on it,may I submit a patch?

Assignee: nobody → gaurijove
Status: NEW → ASSIGNED

(In reply to Jayati Shrivastava from comment #2)

Hi if nobody is working on it,may I submit a patch?

Thanks for submitting a patch!

Hi, I think I misinterpreted the bug. Can I please have more details on what exactly needs to be done?

Flags: needinfo?(htsai)
Flags: needinfo?(hsivonen)

Please change mScriptReferrerPolicy to enum-typed mReferrerPolicy and use it to carry Referrer Policy in all cases. Please change mReferrerPolicyOrIntegrity to mIntegrity and use it to carry integrity attribute values only.

Flags: needinfo?(htsai)
Flags: needinfo?(hsivonen)
Attachment #9138027 - Attachment description: Bug 1508254 - Change referrerpolicy nstring to enum ReferrerPolicy in speculative loading. r=hsivonen → Bug 1508254 - Change mScriptReferrerPolicy to mReferrerPolicy and mReferrerPolicyOrIntegrity to mIntegrity in speculative loading. r=hsivonen

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: gaurijove → nobody
Status: ASSIGNED → NEW
Severity: normal → S3
Assignee: nobody → cyb.ai.815
Status: NEW → ASSIGNED

With mReferrerPolicyOrIntegrity renamed to mIntegrity, we need to
migrate those places using this field for referrer policy purpose to
use mReferrerPolicy instead. Also, with doing so, we need to change
those nsAString referrer policy arguments to dom::ReferrerPolicy
enum instead so that we can pass the enum referrer policy without
changing it back and forth between enum and string.

Depends on D168192

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Assignee: cyb.ai.815 → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.