1508254 - Change referrerpolicy nstring filed to enum ReferrerPolicy in speculative loading

Status: NEW

(Core :: DOM: HTML Parser, enhancement, P3)

Description

[Thomas Nguyen (:tnguyen)]

Follow up bug 1460920, we should remove the usage of nstring referrerPolicy in 
https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/parser/html/nsHtml5SpeculativeLoad.h#271
to use enum mozilla::net::ReferrerPolicy

Comment 1

[Shrey Gupta]

Hello,I would like to work on this bug

Comment 2

[Jayati Shrivastava]

Hi if nobody is working on it,may I submit a patch?

Comment 3

[Jayati Shrivastava]

Attachment: Bug 1508254 - Change mScriptReferrerPolicy to mReferrerPolicy and mReferrerPolicyOrIntegrity to mIntegrity in speculative loading. r=hsivonen

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Jayati Shrivastava from comment #2)

Hi if nobody is working on it,may I submit a patch?

Thanks for submitting a patch!

Comment 5

[Jayati Shrivastava]

Hi, I think I misinterpreted the bug. Can I please have more details on what exactly needs to be done?

Comment 6

[Henri Sivonen (:hsivonen)]

Please change mScriptReferrerPolicy to enum-typed mReferrerPolicy and use it to carry Referrer Policy in all cases. Please change mReferrerPolicyOrIntegrity to mIntegrity and use it to carry integrity attribute values only.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 6 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.

Comment 8

[Cheng-You Bai [:cybai] UTC+9]

Attachment: Bug 1508254 - Rename mScriptReferrerPolicy to mReferrerPolicy. r?hsivonen

Comment 9

[Cheng-You Bai [:cybai] UTC+9]

Attachment: Bug 1508254 - Rename mReferrerPolicyOrIntegrity to mIntegrity and use mReferrerPolicy properly. r?hsivonen

With mReferrerPolicyOrIntegrity renamed to mIntegrity, we need to
migrate those places using this field for referrer policy purpose to
use mReferrerPolicy instead. Also, with doing so, we need to change
those nsAString referrer policy arguments to dom::ReferrerPolicy
enum instead so that we can pass the enum referrer policy without
changing it back and forth between enum and string.

Depends on D168192

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.