On notification clicking fails to open target URL
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox63 wontfix, firefox64 wontfix, firefox65+ verified, firefox66+ verified)
People
(Reporter: lipart25, Assigned: vlad.baicu)
References
Details
Attachments
(2 files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
|
Details | Review |
Comment 1•7 years ago
|
||
Updated•7 years ago
|
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 6•7 years ago
|
||
Assignee | ||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Assignee | ||
Comment 12•7 years ago
|
||
Updated•7 years ago
|
Assignee | ||
Comment 13•7 years ago
|
||
Upon further investigation some things are not entirely clear to me as notification code goes through gecko in c++. For example, the notifications received with the given STRs are treated as persistent notifications. In Android, these usually are ongoing notifications (e.g. foreground service notifications), however I haven't found docs that could provide more information. I tried to go back to the revision provided in the regression window by Bogdan but I had to revert the entire Oreo series patches as most of those had dependencies on previous patches in order to work properly thus, enlarging the number of patches that might have been responsible for this regression.
Altough my patch doesn't resolve the underlying cause of the issue, in case of persistent notifications we still initialize gecko but handle their actions in the NotificationReceiver, this being a speculative fix.
Assignee | ||
Updated•7 years ago
|
Comment 14•7 years ago
|
||
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c8923903d73
Handle persistent notification actions. r=geckoview-reviewers,snorp
Comment 15•7 years ago
|
||
bugherder |
Comment 16•7 years ago
|
||
Please nominate this for Beta approval when you get a chance. We should also get QA to verify that things are working better with this patch.
Assignee | ||
Comment 17•7 years ago
|
||
Because this is a speculative fix, I am not entirely confident of uplifting this patch to beta without QA verification, going to wait on their input first.
Comment 18•7 years ago
|
||
Hello,
I re-tested this issue on the following builds: FF 66.0a1(latest Nightly) and FF 62.0.3 with a Samsung Galaxy Note 9(Android 8.1.0)
and the issue can still be reproduced on the latest nightly.
Upon further investigation it can be noticed the following:
FF 66.0a1(latest Nightly) Opening the push notification while the FF is in background will resume the FF and no new page/tab is opened.
Opening the push notification when the FF is in foreground nothing happens, no new page/tab is opened (see the video).
FF 62.0.3 When opening the push notification while the FF is in background or foreground it will open a new page/tab everytime (see the video).
Note that for FF 66.0a1 is not working at all, the app is only resumed if tapping on a push notification.
Thanks,
Andrei
Assignee | ||
Comment 19•7 years ago
|
||
Thank you for the input Andrei, reopening the issue and will continue working on a new patch.
Updated•7 years ago
|
Assignee | ||
Comment 20•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Comment 21•7 years ago
|
||
Pushed by opoprus@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e29be447ca75
Use the correct intent for GeckoServicesCreatorService. r=sdaswani
Comment 22•7 years ago
|
||
(In reply to Pulsebot from comment #14)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c8923903d73
Handle persistent notification actions. r=geckoview-reviewers,snorp
Backed out on request.
Backout: https://hg.mozilla.org/integration/autoland/rev/64aa8ab3332b0f84707424779368b5ace23ec761
Comment 23•7 years ago
|
||
bugherder |
Comment 24•7 years ago
|
||
NI Andrei to hopefully verify this fix in time to get it into the Fennec 65 RC build later this week.
Comment 25•7 years ago
|
||
Verified as fixed on the latest Nightly build 66.0a1 following the scenarios from Comment 18 with Samsung Galaxy Note 9 (Android 8.1.0).
A new page was opened every time when I tapped on the push notification even when the Fennec was closed
(video), everything looks good!
Assignee | ||
Comment 26•7 years ago
|
||
Comment on attachment 9037604 [details]
Bug 1508279 - Use the correct intent for GeckoServicesCreatorService. r=sdaswani
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1467840
User impact if declined: Notification actions will not work.
Is this code covered by automated tests?: Unknown
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: Yes
If yes, steps to reproduce: Steps to reproduce:
- Launch FF on Android
- Go to https://gauntface.github.io/simple-push-demo
- Click [Enable push notification] switch
- Activate "Enable Push Notifications" (and authorize permission prompt)
- Add payload text "Test"
- Click [Send a Push via XHR] button
- Swipe to display the notifications
- Press to open the notification
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): The regression has been caused by a wrong parameter. The patch only fixes that issue.
String changes made/needed:
Comment 27•7 years ago
|
||
Comment on attachment 9037604 [details]
Bug 1508279 - Use the correct intent for GeckoServicesCreatorService. r=sdaswani
[Triage Comment]
Fixes issues with notification actions. Approved for Fennec 65.0 RC1.
Comment 28•7 years ago
|
||
bugherder uplift |
Comment 29•7 years ago
|
||
Verified as fixed on RC 65.0.
Thank you!
Updated•5 years ago
|
Description
•