Closed Bug 1508320 Opened Last year Closed 9 days ago

Upgrade psutils to 5.6.3 to pick up fix for Linux kernel 4.19

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox72 fixed)

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: bc, Assigned: egao)

References

Details

Attachments

(1 file)

I ran into an issue with mozsystemmonitor failing due to psutils 5.4.3 not being able to parse /proc/diskstats. It expects 15, 14 or 7 fields but Fedora 29/Kernel 4.19.2 is returning 18. See <https://github.com/giampaolo/psutil/issues/1354> / <https://searchfox.org/mozilla-central/source/third_party/python/psutil/psutil/_pslinux.py#1044>.

The current psutils 5.5.0 does check for 18 fields <https://github.com/giampaolo/psutil/blob/master/psutil/_pslinux.py#L1079> which should fix the issue.
Triaging

:bc so I understand the issue, this is an issue you ran into when you were running it locally?
Flags: needinfo?(bob)
Yes, I see this locally on Fedora 29 but appears to be for any 4.19 kernel. It would only affect developers running tests on recent kernels.
Flags: needinfo?(bob)

Per conversation with :kmoir, I'm going through untriaged bugs in her components and marking the ones which look to be enhancements/tasks with the enhancement severity to get them out of the triage queue.

If this incorrect, please remove the tag.

Severity: normal → enhancement

We manually patched our vendored copy of psutil, but every time someone runs ./mach vendor python those manual changes get undone again. So periodically we accidentally remove the fix. See bug 1212502 comment 22 for an example.

Updating our vendored copy will prevent this from happening again in the future as we won't need the manual patch anymore.

Type: enhancement → defect
See Also: → 1212502
Summary: Upgrade psutils to 5.5.0 for Fedora 29 / Linux 4.19 → Upgrade psutils to 5.5.0 to pick up fix for Linux kernel 4.19

In the CI environment, it appears we already use psutil 5.6.3 which is the second newest revision.

I've pushed to try with 5.5.0 vendored to the tree, and its appears to run fine (expected since CI is pulling from the internal pypi mirror).
https://hg.mozilla.org/try/rev/08504e92d630357eff722248b9bbbf41132e8bd1

I'll push another run to try with 5.6.3 to be in line with the CI environment

Pushed by egao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b1aa58870461
upgrade vendored psutil package to 5.6.3 r=ahal,gbrown
Summary: Upgrade psutils to 5.5.0 to pick up fix for Linux kernel 4.19 → Upgrade psutils to 5.6.3 to pick up fix for Linux kernel 4.19
Status: NEW → RESOLVED
Closed: 9 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.