Closed Bug 1508324 Opened 2 years ago Closed 2 years ago

Generate a list of past changesets to be skipped for blame

Categories

(Developer Services :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Felipe, Assigned: Felipe)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1508002 is creating an hg alias to use the new `hg annotate --skip` support with a pre-established convention of skipping changesets which have "skip-blame" in the commit summary, or changesets listed in a file in the tree.

This file will be used to provide extra changesets that should also be skipped but did not include "skip-blame" in the summary.


CC'ing some people who I know have made large code-formatting changes in the past to help gather this list.
Attached file Scripted changes
This file includes a list of all the large changesets I produced using scripts, and at the end of the file I also added a couple large changesets that I'm aware of even though I'm not the author.

If this is going to be used only for the annotate command and not for the log command, we may want to reduce the list to include only changesets that caused changes on lines that still exist (eg. removing Cc and Ci declarations doesn't need to be skipped in annotate, but it's noise when looking at the log).
I feel like there could be some kind of heuristic like patches that touch 30+ files, and then scrape the commit history to get a list of potential candidates.
Before populating this file with a lot more items, let's get the file created and filled with the same changeset currently in .git-blame-ignore-revs, so that newer additions know what's the expected format of this file.

Unfortunately this file can't have full-line comments like the .git-blame-ignore-revs because the extdata() feature from mercurial won't accept any invalid chars at the beginning of the file
Attachment #9028835 - Flags: review?(ehsan)
Comment on attachment 9028835 [details] [diff] [review]
.hg-annotate-ignore-revs

Review of attachment 9028835 [details] [diff] [review]:
-----------------------------------------------------------------

This isn't too bad, it's self-commenting!
Attachment #9028835 - Flags: review?(ehsan) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6baf9f33a6cd
Create the .hg-annotate-ignore-revs file to be used with hg smart-annotate. r=ehsan DONTBUILD NPOTB
Keywords: leave-open
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4fac48f96e20
Generate list of past changesets to be skipped for blame. r=me NPOTB DONTBUILD
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/4fac48f96e20
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
See Also: → 1516755
You need to log in before you can comment on or make changes to this bug.