Closed
Bug 1508393
Opened 6 years ago
Closed 6 years ago
Enable producing full frame animated images by default
Categories
(Core :: Graphics: ImageLib, enhancement, P3)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: aosmond, Assigned: aosmond)
References
Details
Attachments
(1 file)
I was going to land this as part of recycling, but let's just get it now on its own. It will be good to have a nightly produced with just this setting.
Assignee | ||
Comment 1•6 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc569457aeeadabc94746d042b5e69bea4a5c8e2
Priority: -- → P3
Assignee | ||
Comment 2•6 years ago
|
||
Also, fix a minor bug where when we discard an animated image that is a
full frame animated image, we need to reset
AnimationState::mCompositedFrameInvalid to false, just like we do for
animated images blended by FrameAnimator. This is because it is used as
part of our state checking in FrameAnimator::GetCompositedFrame before
we are willing to yield frame data.
Assignee | ||
Comment 3•6 years ago
|
||
Okay, that was harder than I thought....
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b472593dab9565f1f6ab40923c5a519aedda440b
Assignee | ||
Comment 4•6 years ago
|
||
Apparently it is also hard if you somehow lost most of the patch in the push...for real this time:
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=919d7a8006a516c8f9549bb6278a76641bf71170
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c7a3fc19c85
Enable animated images producing full frames by default. r=tnikkel
Assignee | ||
Updated•6 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Updated•6 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Comment 6•6 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
![]() |
||
Updated•6 years ago
|
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•