1508432 - Consider using `mozilla::Hash{Map, Set}` for GeckoView history

Status: NEW

(GeckoView :: General, enhancement, P3)

Description

[Lina Butler [:lina]]

https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/mfbt/HashTable.h#53-72 describes the differences between `mozilla::HashTable` and `ns{Data, T}Hashtable`. TL;DR: The former is faster, but at the cost of increasing executable size.

However, recording a history visit using our Places library already takes an IPC message from child to parent, a JNI call to Java, a JNA call into Rust then back into Java, another JNI call back into Gecko, and yet another IPC message back to the child...so I doubt a hashtable is going to be our bottleneck. We can profile, and switch if it turns out to be an issue, though.

Comment 1

[Lina Butler [:lina]]

Emilio, CCing you because you've been doing a lot of work in the history code recently. 😁

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah, I'd be surprised if the perf of the hash table mattered here.

Comment 3

[Chris Peterson [:cpeterson]]

Tasks and enhancements should have severity N/A.