Open Bug 1508432 Opened 4 years ago Updated 3 years ago

Consider using `mozilla::Hash{Map, Set}` for GeckoView history

Categories

(GeckoView :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: lina, Unassigned)

References

Details

https://searchfox.org/mozilla-central/rev/b03a62c3c82316e733a3b09622c1cb7e59f64cc3/mfbt/HashTable.h#53-72 describes the differences between `mozilla::HashTable` and `ns{Data, T}Hashtable`. TL;DR: The former is faster, but at the cost of increasing executable size.

However, recording a history visit using our Places library already takes an IPC message from child to parent, a JNI call to Java, a JNA call into Rust then back into Java, another JNI call back into Gecko, and yet another IPC message back to the child...so I doubt a hashtable is going to be our bottleneck. We can profile, and switch if it turns out to be an issue, though.
Product: Firefox for Android → GeckoView

Emilio, CCing you because you've been doing a lot of work in the history code recently. 😁

Yeah, I'd be surprised if the perf of the hash table mattered here.

You need to log in before you can comment on or make changes to this bug.