Open Bug 1508466 Opened 6 years ago Updated 2 years ago

Assertion failure: HasEffectiveAnimationOfProperty(property.mProperty, *effectSet) (There should be an effective animation of the property while it is marked as being run on the compositor) at KeyframeEffect.cpp:1297

Categories

(Core :: DOM: Animation, defect, P3)

defect

Tracking

()

Tracking Status
firefox65 --- affected

People

(Reporter: hiro, Unassigned)

Details

Attachments

(1 file)

Attached patch The crash testSplinter Review
Attaching crash test causes an assertion in KeyframeEffect::CanThrottle(). The assertion means that there is no effective properties for compositor but still isRunningOnCompositor flag is true for the properties. This is caused by an issue that, when the opacity animation in the crash test is blocked by a !important rule the corresponding layer backend changes to LAYERS_BASIC, thus we bail out [1] early from nsDisplayListBuilder::AddAnimationsAndTransitionsToLayer without clearing isRunningOnCompositor. Unfortunately clearing isRunningOnCompositor there makes test_animation_performance_warning.html failure pretty high frequent [2], so there must be another underlying issue or the test itself has been flaky in the first place. (But I can't reproduce the failure on local Android emulator) [1] https://hg.mozilla.org/mozilla-central/file/bd4cebdbed4b/layout/painting/nsDisplayList.cpp#l831 [2] https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=212131323&revision=f112289dccd5940ce0f4dc0828fab272017ead93
Attachment #9026244 - Attachment is patch: true
Attachment #9026244 - Attachment mime type: application/octet-stream → text/plain
bughunter has seen this live at <https://www.digitec.ch/de/s1/product/microsoft-office-home-student-2019-deutsch-windows-mac-os-x-office-software-9673334?tagIds=88-1200> on Windows and Linux. I've reproduced locally on Fedora 29 just by loading the url.

Bughunter reproduces with http://www.iransetup.com/Security/Nod32.html#DownloadAV on Linux at least.

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: