1508581 - RTL support in the Flexbox inspector panels

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

Attachment: Screenshot 2018-11-20 at 10.22.58.png

In RTL builds of Firefox, the new Flexbox panels have some issues.
Please see the attached screenshot where I have tried to highlight all of the places that need fixing.

In the flex container panel:
- in the list of items, the flex item index should come first (right)
- in the list of items, the arrow should come last (left) and point the other way

In the flex item panel:
- the back arrow to go back to the flex container panel should point the other way
- the little line next to the final, basis, min, max labels in the minimap are on the wrong side of the label
- the grow/shrink arrow head in the minimap point the wrong way
- the + sign in the flexibility section, next to the value, should come before the number
- the CSS properties (in parenthesis) should come after the title.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Bug 1508581 - Fix a few UI inconsistencies in the flex inspector in RTL; r?miker!

Comment 2

[Patrick Brosset <:pbro>]

Try push for this fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b01e56354340c8b5bc625b04e65c80c8326c11f

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e14fb4f0ce82
Fix a few UI inconsistencies in the flex inspector in RTL; r=miker

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e14fb4f0ce82