Closed Bug 1508602 Opened 6 years ago Closed 4 years ago

GetPropertyPure calls in Stream.cpp are bizarre

Categories

(Core :: JavaScript Engine, defect, P2)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: jorendorff, Assigned: jorendorff)

References

(Blocks 1 open bug)

Details

arai noticed this while reviewing <https://phabricator.services.mozilla.com/D12350>. There are two calls, reading .done and .value out of an iterator result. The calls are infallible but are written with (broken) error handling anyway. They should be slot reads, probably.
Assignee: nobody → jorendorff

There a no more GetPropertyPure under builtin/streams. The call in TeeReaderReadHandler was removed by https://hg.mozilla.org/mozilla-central/rev/ba76b651e79f2773cfdc2546e20afb064865501b.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.