1508694 - Turn off talos stylo sequential threads tp6

Status: RESOLVED FIXED

(Testing :: Talos, enhancement, P1)

Description

[Robert Wood [:rwood]]

Now that Raptor is in production tier 1, there is just one Talos tp6 remaining: talos stylo-sequential threads tp6 i.e. [1].

I would like to turn that test job off since all the other tp6 jobs are in Raptor now. Question is, do we still need to run Stylo Threads on tp6? If so, we'll need to add support for that to Raptor, similar to how we did with Talos.

[1] https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=talos%2Ctp6&revision=51c30c756ab0a558a97113b5a5ac77339857553a

Comment 1

[Robert Wood [:rwood]]

:heycam, when you're back, can you confirm - can we turn off the talos pageload tp6 stylo threads job? Or do we need to add a similar job to tp6 Raptor? Thanks!

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

as this is 5 months old, I assume we can turn this off as there is no reply.

Comment 3

[Florin Strugariu [:Bebe]]

after discussion in the raptor meeting we decided to move these tests to Raptor tests.

The test port would be with the same number of tests found in Talos.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

is there a need for moving this? if so, moving to raptor makes sense.

Comment 5

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Joel Maher ( :jmaher ) (UTC-4) from comment #4)

is there a need for moving this? if so, moving to raptor makes sense.

We've been unable to get an answer... Do you propose we just remove the tests from Talos instead of moving them to Raptor first? I am concerned that if we're unable to get an answer on whether these tests are required, any regression detected by these tests may equally find nobody responsive to them.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

it has been 6 months, I am not aware of another contact for this test, it wouldn't be too hard to turn on in the future.

Comment 7

[Cameron McCormack (:heycam)]

Very sorry for not replying earlier. I think we do want to make sure we don't regress performance of the style system running on a single thread, but we have the style-perftests to check for regressions. So I think it's OK to turn off the single threaded tp6 Talos run. Thank you!

Comment 8

[Florin Strugariu [:Bebe]]

Attachment: Bug 1508694 Turn off talos stylo sequential threads tp6

Comment 9

[Florin Strugariu [:Bebe]]

Not sure if I should just disable the tests in treherder first or also remove the tests from talos.

Jmaher can you offer some guidance here?

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

removing the test from talos is the right way to go.

Comment 11

[Florin Strugariu [:Bebe]]

try build
https://treeherder.mozilla.org/#/jobs?repo=try&revision=35aa97c574ecc370733d075cf150ad1917c058e2

Comment 12

[Florin Strugariu [:Bebe]]

tests run fine locally but I think I broke something on try...

Can someone take a look over the try builds and help please

Comment 13

[Florin Strugariu [:Bebe]]

New try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9ec5aa8e42599a3817e6641ab65246013e226eb&searchStr=talos

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c09907b96986
Turn off talos stylo sequential threads tp6 r=jmaher

Comment 15

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/c09907b96986