1508730 - Expose certificate information in WebResponse

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

This would probably reuse GeckoSession.SecurityInfo (and move it out of GeckoSession).

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1508730 - Expose full X509Certificate in `SecurityInfo` object

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1508730 - Add `WebResponse#isSecure`

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1508730 - Add `WebResponse#certificate`

This is the server certificate, if any, as a
java.security.cert.X509Certificate.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1508730 - Add `WebRequestError#certificate`.

This is useful if you get a certificate-related error and want
to inspect the broken certificate.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15c4a4d8a9f2
Expose full X509Certificate in `SecurityInfo` object r=geckoview-reviewers,droeh,agi
https://hg.mozilla.org/integration/autoland/rev/8e98687f6321
Add `WebResponse#isSecure` r=geckoview-reviewers,droeh,agi
https://hg.mozilla.org/integration/autoland/rev/7deec357e1fc
Add `WebResponse#certificate` r=geckoview-reviewers,droeh,agi
https://hg.mozilla.org/integration/autoland/rev/ea063dbb6c1b
Add `WebRequestError#certificate`. r=geckoview-reviewers,droeh,agi

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1508730 - Ensure `WebExecutorTest#testSslError()` actually throws

Comment 7

[Tom S. (please needinfo tschuster)]

I noticed a potential bug in D58155. Adding a comment here because it is easy to miss comments on phab afterwards.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be7bf28e261f
Ensure `WebExecutorTest#testSslError()` actually throws r=geckoview-reviewers,twisniewski

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/15c4a4d8a9f2
https://hg.mozilla.org/mozilla-central/rev/8e98687f6321
https://hg.mozilla.org/mozilla-central/rev/7deec357e1fc
https://hg.mozilla.org/mozilla-central/rev/ea063dbb6c1b

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/be7bf28e261f