1508757 - Make NOT_REMOTE a real remote type

Status: NEW

(Core :: DOM: Content Processes, enhancement, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

Currently remoteType values are recorded as one of a series of string values. These are only set for remote browsers, so code which needs to handle the nonremote case handles it as 'E10SUtils.NOT_REMOTE', which is 'null'.

Unfortunately this makes it too easy to accidentally confuse unset/not-passed and set, but not remote when passing around remoteType. It'd probably be a good idea to make E10SUtils.NOT_REMOTE be 'notremote' or similar to avoid this case.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

:bobowen, IIRC you implemented this originally - so ni? for feedback on this idea.

Comment 2

[Bob Owen (:bobowen)]

(In reply to :Nika Layzell from comment #1)
> :bobowen, IIRC you implemented this originally - so ni? for feedback on this
> idea.

Yeah, I'm fine with that.

I originally tried to make it some sort of enum, but I found getting that to work well between JavaScript and c++ was not easy.
I also had the problem of different kinds of web content process, for which (as you know) I came up with the crude but simple hack of them starting with "web".
Again maybe some sort of flag system would suit that better, but at least at the time strings seemed to be the only thing that were easy to pass around, not sure if that has changed.

By the way I hated the name remoteType, but "remote" was already used so heavily as an alias for content process, that anything else seemed more confusing.