Enable ESLint for docshell

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
7 months ago
2 months ago

People

(Reporter: standard8, Assigned: pong7219, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 wontfix, firefox66 wontfix, firefox67 wontfix, firefox68 fixed)

Details

(Whiteboard: [seneca-eslint][lang=js])

Attachments

(2 attachments, 2 obsolete attachments)

Reporter

Description

7 months ago
As part of rolling out ESLint across the tree, we should enable it for the rest of docshell, i.e. all of:

docshell/test/browser/**
docshell/test/iframesandbox/**
docshell/test/mochitest/**
Reporter

Updated

7 months ago
Whiteboard: [seneca-eslint]
Priority: -- → P3

Comment 1

7 months ago
I'll work on this issue if no one has yet
Reporter

Updated

7 months ago
Assignee: standard8 → sathia
Attachment #9031192 - Attachment is obsolete: true
Reporter

Comment 3

3 months ago

I've not heard from Sathia, so opening this out as a mentored bug.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code: https://developer.mozilla.org/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
  3. Start working on this bug
    • Please note:
      • We want to end up with two separate commits. One with the automatic changes, the second with the manual changes.
      • Although you'll change .eslintignore at the start, only the second commit should have the .eslintignore changes. Please follow the suggested commands.
    • Here's what to do:
      1. In .eslintignore, remove the three docshell/test/... lines.
      2. Run eslint ./mach eslint --fix docshell/test
        • This should fix some of the issues.
      3. Inspect the diff to make sure that the indentation of the lines surrounding the changes look ok.
      4. Create a commit of the work so far. Note the extra docshell at the end (this avoids committing .eslintignore at this stage)
        • $ hg commit -m "Bug nnn - Enable ESLint for docshell (automatic changes). r?Standard8" docshell
      5. For the remaining issues, you'll need to fix them by hand. To find them, run ./mach eslint docshell.
      6. Create a second commit of the manual changes, note, there's no directory specifier this time, so .eslintignore will be included.
        • $ hg commit -m "Bug nnn - Enable ESLint for docshell (manual changes). r?Standard8
      7. Post the two commits via phabricator. Please use moz-phab to submit them.
  4. Once the patches are submitted, I'll take a look. If there's any changes necessary I'll comment in Phabricator, so be prepared to update the patches. If there's no changes, I'll request review from a docshell peer, so there may still be more to go.
  5. Once we're happy with the changes, I'll push it to autoland - our integration branch. Your code will then soon be shipping to Firefox users worldwide!
  6. Now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Assignee: sathia → nobody
Mentor: standard8
Keywords: good-first-bug
Whiteboard: [seneca-eslint] → [seneca-eslint][lang=js]
Assignee

Comment 4

3 months ago

Hi Mark,
I could work on this, if that's ok :)

Thanks!

Reporter

Comment 5

3 months ago

Hi Mellina, I've assigned it to you, please start working on it. Feel free to ask questions.

Assignee: nobody → pong7219
Status: NEW → ASSIGNED
Assignee

Comment 6

3 months ago

Hi Mark,

Thanks! I will work on it today and will have updates tomorrow.

Assignee

Updated

3 months ago
Flags: needinfo?(standard8)
Reporter

Comment 9

3 months ago

Hi Mellina, sorry I haven't gotten to look at this yet - I've had lots on the last day or so. I hope to look at it tomorrow if not before.

Flags: needinfo?(standard8)
Assignee

Comment 10

3 months ago

Hi Mark, don't worry! There is a lot to check here as well, I understand.

I just gave a heads-up in case you haven't seen it.

Please take your time.

Reporter

Comment 11

3 months ago

Boris, can you accept the automatic changes as well please?

Flags: needinfo?(bzbarsky)

Sorry, I had missed there were two requests, somehow. Done.

Flags: needinfo?(bzbarsky)
Attachment #9052911 - Attachment is obsolete: true

Comment 14

3 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b338bce4319e
Enable ESLint for docshell (automatic changes). r=Standard8,bzbarsky
https://hg.mozilla.org/integration/autoland/rev/cb0dd2254bc3
Enable ESLint for docshell (manual changes). r=Standard8,bzbarsky

Comment 15

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.