1508819 - Enable ESLint for dom/bindings

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), enhancement, P2)

Description

[Mark Banner (:standard8)]

As part of rolling out ESLint across the tree, we should enable it for dom/bindings.

Comment 1

[Ruihui Yan]

Hi Mark, I would like to work on this one.

Thank you!

Comment 2

[Ruihui Yan]

Hi Mark, I have submitted the commits, but I don't see it here. Could you tell me if it went through fine?

Thank you

Comment 3

[Mark Banner (:standard8)]

(In reply to Ruihui Yan from comment #2)
> Hi Mark, I have submitted the commits, but I don't see it here. Could you
> tell me if it went through fine?

I suspect that you didn't include the bug number, or something else went wrong. It should have given you links to revisions on phabricator (or they'll now be in the commit message headers). You should also be able to see them from the phabricator home page.

If you can, visit them, and select "Edit Revision" near the top-right, then make sure they have the correct "bugzilla bug id".

Otherwise, you'll probably have to try submitting again - check you've got the commit messages as "Bug 1508819 - <description>"

Comment 4

[Ruihui Yan]

Attachment: Bug 1508819 - Enable ESLint for dom/bindings (automatic changes)

Comment 5

[Ruihui Yan]

Attachment: Bug 1508819 - Enable ESLint for dom/bindings (manual changes).

Depends on D13891

Comment 6

[Ruihui Yan]

Attachment: Bug 1508819 - Enable ESLint for dom/bindings (manual changes)

Depends on D13892

Comment 7

[Mark Banner (:standard8)]

Ruihui, it looks like you did the extra changes as a separate changeset, could you use hg histedit and roll the second manual commit into the first, then run moz-phab submit again please?

Comment 8

[Shivam Singhal [ :championshuttler ]]

Hi @Ruihui are you still working on it? If not can I take this up?

Thanks

Comment 9

[Mark Banner (:standard8)]

The patches here are basically complete and I'm waiting for Ruihui to hopefully fix the last issue which was an upload one. If they don't get time, then I can fix the issue (and I would like to make sure Ruihui gets the credit for the work).

Comment 10

[Mark Banner (:standard8)]

I think Ruihui is busy, so I'm going to take this and hopefully get just the last bit pushed.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47b7423393a8
Enable ESLint for dom/bindings (automatic changes) r=nika
https://hg.mozilla.org/integration/autoland/rev/f65788b4d229
Enable ESLint for dom/bindings (manual changes). r=nika

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/47b7423393a8
https://hg.mozilla.org/mozilla-central/rev/f65788b4d229

Comment 13

[Mark Banner (:standard8)]

Assigning back to Ruihui for the record as they did most of the work here. Thanks Ruihui.