1508823 - Enable ESLint for dom/browser-element

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Mark Banner (:standard8)]

As part of rolling out ESLint across the tree, we should enable it for dom/browser-element

Comment 1

[Jagmeet Bhamber]

Hi, I'd like to tackle this bug.

Comment 2

[Jagmeet Bhamber]

Attachment: Bug 1508823 - Enable ESLint for dom/browser-element (manual changes). r?ehsan

Comment 3

[Mark Banner (:standard8)]

Hi Jagmeet, thank you for the patch, but it seems this is only the manual changes commit, and the automatic changes commit is missing.

Did you use `moz-phab submit` with no additional arguments? In theory that should upload correctly.

Comment 4

[Jagmeet Bhamber]

No, I included another argument containing the commit number. I saw a classmate do this who included 2 commits. I used `hg summary` to list my commits but only saw the ID for the manual-changes commit.

What should I do to upload my automatic changes as well?

Comment 5

[Mark Banner (:standard8)]

I believe `hg summary` will only list the top commit. If you use just `moz-phab submit` with no additional arguments then it should automatically work out which commits to post - it will prompt you before hand as well

Comment 6

[Mark Banner (:standard8)]

I've not heard from Jagmeet, so stealing this to see what we can get landed here.

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 1508823 - Enable ESLint for dom/browser-element (automatic changes). r?ehsan

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21cd0b75c1c3
Enable ESLint for dom/browser-element (automatic changes). r=Ehsan
https://hg.mozilla.org/integration/autoland/rev/a52b7d427119
Enable ESLint for dom/browser-element (manual changes). r=mccr8

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/21cd0b75c1c3
https://hg.mozilla.org/mozilla-central/rev/a52b7d427119