1508824 - SharedWorker.onconnect event should be a MessageEvent with an empty string as data

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement, P2)

Description

[Andrea Marchesini [:baku]]

Currently data is a null, but the spec says:

"If is shared is true, then queue a task, using the DOM manipulation task source, to fire an event named connect at worker global scope, using MessageEvent, with the data attribute initialized to the empty string, the ports attribute initialized to a new frozen array containing inside port, and the source attribute initialized to inside port."

Comment 1

[Andrea Marchesini [:baku]]

Attachment: emptyString.patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/434b3eacae09
SharedWorker.onconnect event should be a MessageEvent with an empty string as data, r=asuth

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/434b3eacae09

Comment 4

[Chris Mills [:cmills]]

Note to MDN writers:

I have added a note to the Fx 65 rel notes to cover this change:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#APIs

However we have not yet documented SharedWorker.onconnect, so this needs doing, along with the associated compat data, etc.

Comment 5

[Chris Mills [:cmills]]

I have documented this by

adding a note here:
https://developer.mozilla.org/en-US/docs/Web/API/SharedWorkerGlobalScope/onconnect#Examples

adding a note to the Fx65 rel notes:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/65#Web_workers

I didn't think a specific entry in the browser compat data was appropriate here — it is a pretty minor addition, and would be hard to communicate in the compat data without being confusing.

Let me know if this sounds OK.

Comment 6

[Andrea Marchesini [:baku]]

Perfect. Thanks.