Closed Bug 1508826 Opened 2 years ago Closed 2 years ago

Add mach_override.c and mach_override.h to ThirdPartyPaths

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

These two files are imported. See bug 1508773 for files that should be updated.
Also, xpcom/io/crc32c.c, though that's kind of an excerpt.
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4a6bd0a9e00
Add mach_override.* and crc32c.c to ThirdPartyPaths.txt. r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/b4a6bd0a9e00
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Attached patch ESR patch (obsolete) — Splinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.

String or UUID changes made by this patch: None
Attachment #9031010 - Flags: approval-mozilla-esr60?
Attached patch ESR patchSplinter Review
See comment 5.
Attachment #9031024 - Flags: approval-mozilla-esr60?
Comment on attachment 9031010 [details] [diff] [review]
ESR patch

OK for uplift to ESR for clang-format project.
Attachment #9031010 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Attachment #9031024 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Attachment #9031010 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.