Add mach_override.c and mach_override.h to ThirdPartyPaths

RESOLVED FIXED in Firefox -esr60

Status

()

enhancement
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox65 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Assignee

Description

7 months ago
These two files are imported. See bug 1508773 for files that should be updated.
Assignee

Comment 1

7 months ago
Also, xpcom/io/crc32c.c, though that's kind of an excerpt.

Comment 3

7 months ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4a6bd0a9e00
Add mach_override.* and crc32c.c to ThirdPartyPaths.txt. r=Ehsan

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b4a6bd0a9e00
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65

Comment 5

6 months ago
Posted patch ESR patch (obsolete) — Splinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB.

String or UUID changes made by this patch: None
Attachment #9031010 - Flags: approval-mozilla-esr60?

Comment 6

6 months ago
Posted patch ESR patchSplinter Review
See comment 5.
Attachment #9031024 - Flags: approval-mozilla-esr60?
Comment on attachment 9031010 [details] [diff] [review]
ESR patch

OK for uplift to ESR for clang-format project.
Attachment #9031010 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Attachment #9031024 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+

Updated

6 months ago
Attachment #9031010 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.