Closed
Bug 1508840
Opened 7 years ago
Closed 7 years ago
Handle messages with no execution point in the console
Categories
(Core Graveyard :: Web Replay, enhancement)
Core Graveyard
Web Replay
Tracking
(firefox65 fixed)
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
1.36 KB,
patch
|
jlast
:
review+
nchevobbe
:
review+
|
Details | Diff | Splinter Review |
We don't yet generate seekable execution points for all console messages. The presence of such messages can break the console in a couple ways:
- A seek icon will appear on these messages, but clicking on it won't take the user to that message and may break the console.
- Finding the current paused message can break the console when there are visible messages with no execution point.
The attached patch fixes both of these. In the first case, a clickable seek icon does not appear for messages which can't be seeked to.
Attachment #9026550 -
Flags: review?(nchevobbe)
Assignee | ||
Comment 1•7 years ago
|
||
Comment on attachment 9026550 [details] [diff] [review]
patch
Changing review per request.
Attachment #9026550 -
Flags: review?(nchevobbe) → review?(jlaster)
Updated•7 years ago
|
Attachment #9026550 -
Flags: review?(jlaster) → review+
Comment 2•7 years ago
|
||
Comment on attachment 9026550 [details] [diff] [review]
patch
Review of attachment 9026550 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me too
Attachment #9026550 -
Flags: review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/795cc577254c
Handle messages with no execution point in the console, r=jlast.
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•