1508840 - Handle messages with no execution point in the console

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, enhancement)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

We don't yet generate seekable execution points for all console messages.  The presence of such messages can break the console in a couple ways:

- A seek icon will appear on these messages, but clicking on it won't take the user to that message and may break the console.

- Finding the current paused message can break the console when there are visible messages with no execution point.

The attached patch fixes both of these.  In the first case, a clickable seek icon does not appear for messages which can't be seeked to.

Comment 1

[Brian Hackett [Laid off!]]

Comment on attachment 9026550 [details] [diff] [review]
patch

Changing review per request.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9026550 [details] [diff] [review]
patch

Review of attachment 9026550 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me too

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/795cc577254c
Handle messages with no execution point in the console, r=jlast.

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/795cc577254c