1508849 - fix validation problems

Status: RESOLVED FIXED

(Taskcluster :: Services, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

auth/references/events.json: reference.entries[0].routingKey[0] should have required property 'required'
auth/references/events.json: reference.entries[1].routingKey[0] should have required property 'required'
auth/references/events.json: reference.entries[2].routingKey[0] should have required property 'required'
auth/references/events.json: reference.entries[3].routingKey[0] should have required property 'required'
auth/references/events.json: reference.entries[4].routingKey[0] should have required property 'required'
auth/references/events.json: reference.entries[5].routingKey[0] should have required property 'required'
auth/references/events.json: reference should have required property 'apiVersion'
auth/schemas/v1/create-client-request.json: schema.properties['scopes'].items.pattern should match format "regex"
auth/schemas/v1/create-client-request.json: schema.properties['scopes'].items should be array
auth/schemas/v1/create-client-request.json: schema.properties['scopes'].items should match some schema in anyOf
auth/schemas/v1/create-client-response.json: schema.properties['expandedScopes'].items.pattern should match format "regex"
auth/schemas/v1/create-client-response.json: schema.properties['expandedScopes'].items should be array
auth/schemas/v1/create-client-response.json: schema.properties['expandedScopes'].items should match some schema in anyOf
auth/schemas/v1/create-client-response.json: schema.properties['scopes'].items.pattern should match format "regex"
auth/schemas/v1/create-client-response.json: schema.properties['scopes'].items should be array
auth/schemas/v1/create-client-response.json: schema.properties['scopes'].items should match some schema in anyOf
auth/schemas/v1/create-role-request.json: schema.properties['scopes'].items.pattern should match format "regex"
auth/schemas/v1/create-role-request.json: schema.properties['scopes'].items should be array
auth/schemas/v1/create-role-request.json: schema.properties['scopes'].items should match some schema in anyOf
auth/schemas/v1/get-role-response.json: schema.properties['expandedScopes'].items.pattern should match format "regex"
auth/schemas/v1/get-role-response.json: schema.properties['expandedScopes'].items should be array
auth/schemas/v1/get-role-response.json: schema.properties['expandedScopes'].items should match some schema in anyOf
auth/schemas/v1/get-role-response.json: schema.properties['scopes'].items.pattern should match format "regex"
auth/schemas/v1/get-role-response.json: schema.properties['scopes'].items should be array
auth/schemas/v1/get-role-response.json: schema.properties['scopes'].items should match some schema in anyOf
events/references/api.json: reference should have required property 'apiVersion'
gce-provider/references/api.json: reference should have required property 'apiVersion'
github/references/api.json: reference should have required property 'apiVersion'
github/references/events.json: reference should have required property 'apiVersion'
hooks/references/events.json: reference.entries[0].routingKey[0] should have required property 'required'
hooks/references/events.json: reference.entries[1].routingKey[0] should have required property 'required'
hooks/references/events.json: reference.entries[2].routingKey[0] should have required property 'required'
hooks/references/events.json: reference should have required property 'apiVersion'
login/references/api.json: reference should have required property 'apiVersion'
notify/references/api.json: reference should have required property 'apiVersion'
notify/references/events.json: reference.entries[0].routingKey[0].constant should be string
notify/references/events.json: reference.entries[0].routingKey[0] should have required property 'multipleWords'
notify/references/events.json: reference.entries[0].routingKey[1].constant should be string
notify/references/events.json: reference.entries[0].routingKey[1] should have required property 'required'
notify/references/events.json: reference should have required property 'apiVersion'
purge-cache/references/api.json: reference should have required property 'apiVersion'
queue/references/events.json: reference.entries[0].routingKey[9] should have required property 'required'
queue/references/events.json: reference.entries[1].routingKey[9] should have required property 'required'
queue/references/events.json: reference.entries[2].routingKey[9] should have required property 'required'
queue/references/events.json: reference.entries[3].routingKey[9] should have required property 'required'
queue/references/events.json: reference.entries[4].routingKey[9] should have required property 'required'
queue/references/events.json: reference.entries[5].routingKey[9] should have required property 'required'
queue/references/events.json: reference.entries[6].routingKey[9] should have required property 'required'
queue/references/events.json: reference.entries[7].routingKey[3] should have required property 'required'
queue/references/events.json: reference should have required property 'apiVersion'
queue/schemas/v1/task.json: schema.properties['scopes'].items.pattern should match format "regex"
queue/schemas/v1/task.json: schema.properties['scopes'].items should be array
queue/schemas/v1/task.json: schema.properties['scopes'].items should match some schema in anyOf
secrets/references/api.json: reference should have required property 'apiVersion'

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-lib-pulse/pull/26

errors like
  secrets/references/api.json: reference should have required property 'apiVersion'
will be fixed when services are upgraded to the latest versions of tc-lib-pulse and tc-lib-api.

Same for
  notify/references/events.json: reference.entries[0].routingKey[0].constant should be string

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/taskcluster-auth/pull/182 fixes the errors about matching format "regex", except for the one in the queue.

Comment 3

[Dustin J. Mitchell [:dustin] (he/him)]

Same for the queue:
  https://github.com/taskcluster/taskcluster-queue/pull/301

I believe that covers all of the validation errors.  Now everything needs a tc-lib-pulse/tc-lib-api bump as well as landing these PRs.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-auth

https://github.com/taskcluster/taskcluster-auth/commit/b19103d6d2ac47d16e2086a283e04320651ff383
Bug 1508849 - implement **-scope protection differently

The old solution used a negative lookbehind, which per
https://json-schema.org/understanding-json-schema/reference/regular_expressions.html#regular-expressions
is not supported in json-schema.  In fact, it's not supported in even
fairly recent versions of Node.  This causes problems when validating
schemas using those old versions of node (or using json-schema
validators that do not support this form).

So, the new solution is to explicitly forbid those forms where used in
creating clients and roles.  The result is much the same, as evidenced
by the minimal changes to the tests.

https://github.com/taskcluster/taskcluster-auth/commit/052d624ea730559489f6984b8fb47b819e2ffe94
Merge pull request #182 from djmitche/bug1508849

Bug 1508849 - implement **-scope protection differently

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-queue

https://github.com/taskcluster/taskcluster-queue/commit/936be6b0b42002fbae57b69a6b4f7acabf82d8ac
Bug 1508849 - implement **-scope protection differently

The old solution used a negative lookbehind, which per
https://json-schema.org/understanding-json-schema/reference/regular_expressions.html#regular-expressions
is not supported in json-schema. In fact, it's not supported in even
fairly recent versions of Node. This causes problems when validating
schemas using those old versions of node (or using json-schema
validators that do not support this form).

So, the new solution is to explicitly forbid those forms where used in
creating clients and roles. The result is much the same, as evidenced
by the minimal changes to the tests.

https://github.com/taskcluster/taskcluster-queue/commit/bed26fb8855ee4c96174be3f9200cf4965f75a1d
Merge pull request #301 from djmitche/bug1508849

Bug 1508849 - implement **-scope protection differently