Prepare the Linux sandbox code for reformatting

RESOLVED FIXED in Firefox -esr60

Status

()

defect
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: jld, Assigned: jld)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Unspecified
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox65 fixed)

Details

Attachments

(1 attachment)

There are a few things in the Linux sandbox code where the upcoming reformat (bug 1188202) will mess up some intentional vertical alignment.  The enums I'm not too bothered by, but the socketcall/ipc table in SandboxFilterUtil.cpp is, I think, worth keeping in its current tabular form.  I have a patch….
The tables in SandboxFilterUtil.cpp should remain vertically aligned,
but clang-format would disagree.  This patch excludes that region from
reformatting, and applies the other changes that clang-format would make
there.

Comment 2

6 months ago
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/023c546c01cd
Prepare the Linux sandbox's socketcall/ipc-call dispatch table for reformatting. r=gcp

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/023c546c01cd
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9026592 [details]
Bug 1508898 - Prepare the Linux sandbox's socketcall/ipc-call dispatch table for reformatting.

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is whitespace change.

String or UUID changes made by this patch: None
Attachment #9026592 - Flags: approval-mozilla-esr60?
Comment on attachment 9026592 [details]
Bug 1508898 - Prepare the Linux sandbox's socketcall/ipc-call dispatch table for reformatting.

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9026592 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.