1508962 - Add a BaselineCodeGen<Handler> class to abstract opcode compilation

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement, P2)

Description

[Jan de Mooij [:jandem]]

For bug 1499324 we want to add a BaselineCodeGen<Handler> base class to BaselineCompiler, so we can share most of the implementation code between compiler and interpreter.

The first patch here will move all the emit_JSOP_* methods (and fields/methods they depend on) to BaselineCodeGen. Then we can incrementally start using template specialization and the Handler template to abstract them.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1508962 part 1 - Add a BaselineCodeGen<Handler> base class to BaselineCompiler and use it for JSOp compilation. r?djvj

This is just the first step: the Handler classes are still empty and
BaselineCodeGen contains fields/methods that should eventually move out of
there. That will happen in follow-up patches.

Depends on D11746

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1508962 part 2 - Implement emitDebugInstrumentation to abstract emitting debugging-specific code. r?djvj

Depends on D12522

Comment 3

[Jan de Mooij [:jandem]]

I'm pretty happy with how part 2 turned out. We can use lambdas like this for other things as well, where the interpreter will call both of them + emit a branch and the compiler/JIT will call just one depending on static information.

Comment 4

[Jan de Mooij [:jandem]]

(In reply to Jan de Mooij [:jandem] from comment #3)
> We can use lambdas like this
> for other things as well, where the interpreter will call both of them +
> emit a branch and the compiler/JIT will call just one depending on static
> information.

And this (the code in emitDebugInstrumentation) can probably be abstracted more, if it becomes a common pattern. However that will be easier to do down the road when we know what the other uses are like.

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1508962 part 3 - Eliminate some *pc uses where we know the JSOp statically. r?djvj

Depends on D12523

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1508962 part 4 - Abstract jump opcodes in BaselineCodeGen. r?djvj

Depends on D12922

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77764799fba3
part 1 - Add a BaselineCodeGen<Handler> base class to BaselineCompiler and use it for JSOp compilation. r=djvj
https://hg.mozilla.org/integration/autoland/rev/e0b75c94bc06
part 2 - Implement emitDebugInstrumentation to abstract emitting debugging-specific code. r=djvj
https://hg.mozilla.org/integration/autoland/rev/c315f5473734
part 3 - Eliminate some *pc uses where we know the JSOp statically. r=djvj
https://hg.mozilla.org/integration/autoland/rev/863959eb64d1
part 4 - Abstract jump opcodes in BaselineCodeGen. r=djvj

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/77764799fba3
https://hg.mozilla.org/mozilla-central/rev/e0b75c94bc06
https://hg.mozilla.org/mozilla-central/rev/c315f5473734
https://hg.mozilla.org/mozilla-central/rev/863959eb64d1