Enable ESLint for dom/base/test/chrome and dom/base/test/unit

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
5 months ago
a month ago

People

(Reporter: standard8, Assigned: contact)

Tracking

(Blocks 1 bug)

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 wontfix, firefox66 fixed)

Details

(Whiteboard: [seneca-eslint])

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

5 months ago
As part of rolling out ESLint across the tree, we should enable it for dom/base/test/chrome and dom/base/test/unit.
(Reporter)

Updated

5 months ago
Depends on: 1508980
Priority: -- → P3
(Assignee)

Comment 1

5 months ago
May I work on this?
(Reporter)

Updated

5 months ago
Assignee: standard8 → contact
(Assignee)

Comment 3

5 months ago
Depends on D13128
(Assignee)

Comment 4

5 months ago
Depends on D13129
(Assignee)

Comment 5

5 months ago
Depends on D13130
(Assignee)

Comment 6

5 months ago
Sorry for the awkward, tacked on extra bug number, I did the "-b 1508983" appending in moz-phab out of worry that it wouldn't pick up on the # before the number. Any way to remove it?
(Reporter)

Comment 7

5 months ago
(In reply to mordax from comment #6)
> Sorry for the awkward, tacked on extra bug number, I did the "-b 1508983"
> appending in moz-phab out of worry that it wouldn't pick up on the # before
> the number. Any way to remove it?

When you do your next update, if you use `hg histedit` you can use the "mess" (m) option to change the message for each commit. Generally just make the commit message "Bug 1508983 - Enable ESLint for dom/base/test/unit (manual changes)" with no #.

Once you've done the changes, you should be able to run `moz-phab submit` again and it'll update the titles for you. If you're not using moz-phab, then just go into the revisions on phabricator and select "Edit Revision", from there you can change it.
Attachment #9028045 - Attachment description: Bug 1508983 - Bug #1508983 - Enable ESLint for dom/base/test/chrome (automatic changes) → Bug 1508983 - Enable ESLint for dom/base/test/chrome (automatic changes)
Attachment #9028048 - Attachment description: Bug 1508983 - Bug #1508983 - Enable ESLint for dom/base/test/chrome/ (manual changes) → Bug 1508983 - Enable ESLint for dom/base/test/chrome/ (manual changes)
Attachment #9028050 - Attachment description: Bug 1508983 - Bug #1508983 - Enable ESLint for dom/base/test/unit (automatic changes) → Bug 1508983 - Enable ESLint for dom/base/test/unit (automatic changes)
Attachment #9028056 - Attachment description: Bug 1508983 - Bug #1508983 - Enable ESLint for dom/base/test/unit (manual changes) → Bug 1508983 - Enable ESLint for dom/base/test/unit (manual changes)
Attachment #9028849 - Attachment is obsolete: true
I'm on PTO so you'll get faster reviews from somebody else.
(Reporter)

Comment 10

4 months ago
Ok, thanks Andrew.

Comment 11

4 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/002907f3b577
Enable ESLint for dom/base/test/chrome (automatic changes) r=Standard8,smaug
https://hg.mozilla.org/integration/autoland/rev/61192787a882
Enable ESLint for dom/base/test/chrome/ (manual changes) r=Standard8,smaug
https://hg.mozilla.org/integration/autoland/rev/dd6e480be253
Enable ESLint for dom/base/test/unit (automatic changes) r=Standard8,mccr8
https://hg.mozilla.org/integration/autoland/rev/6b3257019239
Enable ESLint for dom/base/test/unit (manual changes) r=Standard8,smaug
(Reporter)

Comment 13

4 months ago
This has now landed on the main branch. Mordax, thank you for working on this.
(Assignee)

Comment 14

4 months ago
(In reply to Mark Banner (:standard8) from comment #13)
> This has now landed on the main branch. Mordax, thank you for working on
> this.

No, thank you! Sorry for the lack of banter, I've been like the living dead these few days due to the end of my semester. Thanks for your direction and really helpful reviews, I'm glad you were our mentor! I'll be sticking around if you folks don't mind, this was a really enjoyable experience!
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.